avoid rendering empty trees on a11y tree #14239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related forum issue: https://forum.babylonjs.com/t/accessibility-empty-accessibility-node-for-any-adt-added-even-if-empty/43415/7
Previously, if we reached a texture ADT, we would render at least the root node, even if it was empty (no children and no description). Now this scenario is checked, and if it occurs, we skip rendering that tree. This avoids empty divs on the twin tree.