Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All Add... methods should propose an override with Action<MicrosoftIdentityOptions> #2

Closed
jennyf19 opened this issue Feb 18, 2020 · 1 comment
Closed

All Add... methods should propose an override with Action<MicrosoftIdentityOptions> #2

jennyf19 opened this issue Feb 18, 2020 · 1 comment
Labels
enhancement New feature or request fixed
Milestone
First NuGet package

Comments

@jennyf19
Copy link
Collaborator

Why?
Today all Microsoft.Identity.Web public API named Add.XXX propose an override with a config file section name. Some to propose an override with an Action<>

What?
Ensure that both overrides exists, to let use plug-in their configuration the way they want

Context:
recommended by Chris Ross/ASP.NET Core

Copied from Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2#288
@jennyf19 jennyf19 added the enhancement New feature or request label Feb 18, 2020
@jennyf19 jennyf19 mentioned this issue Feb 18, 2020
Closed
@jmprieur jmprieur mentioned this issue Feb 24, 2020
Closed
5 tasks
@jmprieur jmprieur added this to the First NuGet package milestone Apr 3, 2020
@jmprieur jmprieur added the fixed label Apr 3, 2020
@jennyf19
Copy link
Collaborator Author

Included in [release]https://github.com/AzureAD/microsoft-identity-web/releases/tag/0.1.0-preview)

@jennyf19 jennyf19 mentioned this issue Sep 5, 2023
Merged
@BernieEllis BernieEllis mentioned this issue Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fixed
Projects
None yet
Milestone
First NuGet package
Development

No branches or pull requests
2 participants
@jmprieur @jennyf19