-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed Identity in MSALJS #6880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR covers the API for the new (MSAL-Node specific) Managed Identity Client. Only the App Service source has been implemented for now. The Azure Arc, CloudShell, IMDS and Service Fabric sources will be in another PR. The following is how a developer will create a new managed identity client and acquire a token ``` import * as msal from "@azure/msal-node"; // optional const config: msal.ManagedIdentityConfiguration = { // optional managedIdentityIdParams: { userAssignedClientId: "managed_identity_id" }, system: { // optional loggerOptions: msal.LoggerOptions; // optional networkClient: msal.INetworkModule; // optional proxyUrl: string; // optional customAgentOptions: http.AgentOptions | https.AgentOption; // optional }, }; // required const request: msal.ManagedIdentityRequest = { forceRefresh: true, // optional, defaults to false resource: "URI_of_the_managed_identity_assigned_to_the_azure_resource" // required }; .................. try { const managedIdentityClient = new msal.ManagedIdentityClient(config); const response = await managedIdentityClient.acquireToken(request); console.log(response); } catch (error) { console.log(error); } ``` --------- Co-authored-by: Robbie Ginsburg <rgins16@gmail.com>
…ture Branch (#6681) Co-authored-by: Robbie Ginsburg <rgins16@gmail.com>
…on the Source Type (#6751)
…tatic caching commit
Successfully ran sample on an Azure VM
In making the Service Fabric + Cloud Shell code as efficient as possible, several code improvements that affect the other managed identity sources were implemented as well. Cloud Shell has been manually tested Service Fabric still needs to be manually tested
github-actions
bot
added
documentation
Related to documentation.
samples
Related to the samples apps for the library.
msal-node
Related to msal-node package
msal-common
Related to msal-common package
labels
Feb 6, 2024
bgavrilMS
reviewed
Feb 8, 2024
bgavrilMS
reviewed
Feb 8, 2024
bgavrilMS
reviewed
Feb 23, 2024
bgavrilMS
reviewed
Feb 23, 2024
bgavrilMS
reviewed
Feb 23, 2024
This sample is almost identical to the Azure VM sample. Only the README really needs to be reviewed.
neha-bhargava
approved these changes
Mar 26, 2024
neha-bhargava
approved these changes
Mar 26, 2024
bgavrilMS
approved these changes
Mar 26, 2024
pmaytak
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in lieu of Neha's approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Related to documentation.
msal-common
Related to msal-common package
msal-node
Related to msal-node package
samples
Related to the samples apps for the library.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Managed Identity in MSALJS. The following sources can be used to create a Managed Identity application:
Tested all sources manually, and have unit tests which make fake network requests.