New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix addEventCallback input parameter type #6353
Conversation
Can we add tests to match the type? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything we can do to properly test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix, Thomas!
Generally speaking testing types is done by the TypeScript compiler, you can't really write unit tests against non-primitive types because types are stripped at runtime. Functionally nothing changes here, this is purely a TypeScript change. We do have tests for the |
Fixes input parameter type for addEventCallback which broke when moving from v2 to v3
Addresses #6309