Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed http(s) import errors in msal-node #6349

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Fixed http(s) import errors in msal-node #6349

merged 6 commits into from
Aug 16, 2023

Conversation

Robbie-Microsoft
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added samples Related to the samples apps for the library. msal-node Related to msal-node package labels Aug 15, 2023
@Robbie-Microsoft Robbie-Microsoft linked an issue Aug 15, 2023 that may be closed by this pull request
No matching export in "node-modules-polyfills:http" for import "createServer" #5602
Closed
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023 •
edited

Codecov Report

Merging #6349 (4d93d47) into dev (81d34b4) will decrease coverage by 5.70%.
Report is 258 commits behind head on dev.
The diff coverage is n/a.

Flag Coverage Δ
msal-angular ?
msal-browser ?
msal-common ?
msal-core ?
msal-node 79.29% <ø> (-4.10%) ⬇️
msal-node-extensions ?
msal-react ?
node-token-validation ?

see 236 files with indirect coverage changes

@Robbie-Microsoft Robbie-Microsoft merged commit 4d23a90 into dev Aug 16, 2023
29 checks passed
@Robbie-Microsoft Robbie-Microsoft deleted the http_import_error branch August 16, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectormmg hectormmg hectormmg approved these changes

@tnorling tnorling tnorling approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@jennyf19 jennyf19 Awaiting requested review from jennyf19

@jmprieur jmprieur Awaiting requested review from jmprieur

Assignees
No one assigned
Labels
msal-node Related to msal-node package samples Related to the samples apps for the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No matching export in "node-modules-polyfills:http" for import "createServer"
4 participants
@Robbie-Microsoft @codecov-commenter @hectormmg @tnorling