Node broker implementation #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-library-for-js into node-extensions-nativeBrokerPlugin
…tion-library-for-js into node-extensions-nativeBrokerPlugin
…tion-library-for-js into node-extensions-nativeBrokerPlugin
…tion-library-for-js into node-extensions-nativeBrokerPlugin
github-actions
bot
added
documentation
tnorling
requested review from
jennyf19,
jmprieur,
bgavrilMS and
Robbie-Microsoft
as code owners
peterzenz
approved these changes
Feb 22, 2023
derisen
reviewed
Feb 22, 2023
| * @param request | ||
| * @returns | ||
| */ | ||
| async signOut(request: SignOutRequest): Promise<void> { |
There was a problem hiding this comment.
Slightly worried if this could be mistaken for an API doing a service signout (end session). I suppose the name was chosen to align with X.. (likely lacking context, apologies)
There was a problem hiding this comment.
signOut API has the same name across all MSAL APIs except formsal-browser. What do you have in mind?
There was a problem hiding this comment.
@sameerag didn't know that! My worry is, this API only does a "local" signout, it doesn't end the session with IdP. We probably should emphasize this in API description as it's reasonable to expect this to be misunderstood.
derisen
reviewed
Feb 22, 2023
derisen
reviewed
Feb 22, 2023
derisen
reviewed
Feb 22, 2023
samples/msal-node-samples/auth-code-cli-brokered-app/src/index.js
Outdated
Show resolved
Hide resolved
sameerag
reviewed
Feb 22, 2023
sameerag
reviewed
Feb 22, 2023
| ...remainingProperties, | ||
| clientId: this.config.auth.clientId, | ||
| scopes: request.scopes || OIDC_DEFAULT_SCOPES, | ||
| redirectUri: `${Constants.HTTP_PROTOCOL}${Constants.LOCALHOST}`, |
There was a problem hiding this comment.
Basic q: Is it set this way as we do not need it for the native calls?
Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
sameerag
approved these changes
Feb 27, 2023
hectormmg
approved these changes
Feb 27, 2023
…tion-library-for-js into msal-node-brokering
…osoft-authentication-library-for-js into msal-node-brokering
github-actions
bot
added
the
extensions
|
🎉 Handy links: |
konstantin-msft
pushed a commit
that referenced
this pull request
Apr 3, 2023
Exposes nativeBrokerPlugin to enable token acquisition through the system broker via msal-node-extensions and msal-runtime --------- Co-authored-by: Thomas Norling <thnorlin@microsoft.com> Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
hectormmg
pushed a commit
that referenced
this pull request
Apr 5, 2023
Exposes nativeBrokerPlugin to enable token acquisition through the system broker via msal-node-extensions and msal-runtime --------- Co-authored-by: Thomas Norling <thnorlin@microsoft.com> Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes nativeBrokerPlugin to enable token acquisition through the system broker via msal-node-extensions and msal-runtime