Split classes out into files #2
Merged
+1,241
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shivbijlani, |
kpanwar
approved these changes
Apr 1, 2017
| static get accessToken(): string { return "access_token"; } | ||
| static get expiresIn(): string { return "expires_in"; } | ||
| static get sessionState(): string { return "session_state"; } | ||
| static get tokenKeys(): string { return "adal.token.keys"; } |
There was a problem hiding this comment.
as a part of refactor can we replace all "adal" with "msal"?
| @@ -1,14 +1,18 @@ | |||
| { | |||
| "compileOnSave": true, | |||
| "compilerOptions": { | |||
| "target": "es5", | |||
| "module": "commonjs", | |||
| "target": "es5", | |||
There was a problem hiding this comment.
@rohitnarula7176 - I thought we were targeting es6?
Closed
pkanher617
pushed a commit
that referenced
this pull request
Jun 17, 2020
[msal-node][#2] Merge cache logic in `msal-common` for `node` and `browser` platforms
sangonzal
added a commit
that referenced
this pull request
Jun 30, 2020
[msal-extensions] Extensions #2
3 tasks
tnorling
added a commit
that referenced
this pull request
Aug 4, 2020
Telemetry #2: Implement Telemetry in msal-browser
pkanher617
pushed a commit
that referenced
this pull request
Aug 26, 2020
Broker #2: Sending auth requests
pkanher617
pushed a commit
that referenced
this pull request
Aug 28, 2020
AT Proof-Of-Possession #2: Handle proof-of-possession tokens correctly in responses
hectormmg
added a commit
that referenced
this pull request
Feb 2, 2022
* Add KeyManager class * Add STK JWK to BaseAuthRequest * Add STK generation logic to common and browser * Update PublicClientApplication tests to mock out STK generation from Auth Code requests * Undo msal-node-samples changes * Move generateCnf from PopTokenGenerator to KeyManager * Refactor crypto key generation to use different key generation algorithm options for AT and RT PoP * Add missing API from Crypto Interface to msal-node * Fix linter issues * Add rtPop msal-browser sample * Add stk_jwk to /authorize call in AuthorizationCodeClient to initiate bound rt flow * Add STK JWK to /token request to obtain bound rt response * Add stkJwk to AuthorizationCodeClient tests * Update mock crypto interface in tests * Fix merge conflicts * Cleanup tests * Refactor Cryptographic constants out of BrowserConstants and CryptoOps * Fix generatePublicKeyThumbprint stubs and expected values on tests * Fix tests after merge * Add feature flag to make RT Binding opt-in * Add error handling to STK generation step * Refactor crypto enum names * Add error handling for crypto key generation * Put KeyManager instance in BaseClient instead of AuthCode and Refresh Clients * Fix import in BaseClient * Extend KeyManager tests * Increase test coverage * Update lib/msal-browser/src/utils/CryptoConstants.ts * Fix merge conflicts * Add boundRT sample * Undo unnecessary method position change * Add initial e2e tests for RT PoP * Revert to headless false for boundRT e2e test * Update lib/msal-common/test/client/RefreshTokenClient.spec.ts Co-authored-by: Thomas Norling <thomas.l.norling@gmail.com> * Fix incorrect typing and checks for private key on getPublicKeyThumbprint * Refactor cryptographic constants to have more consistent casing * Fix CryptoOps tests around getPublicKeyThumbprint * Move refreshTokenBinding feature flag to system config * Update browser client config to move refreshTokenBinding flag to system config * Rename KeyManager to CryptoKeyManager for more specificity * Update BrowserAuthError to remove keyId from error message and avoid Pii * Update lib/msal-browser/src/config/Configuration.ts * Update sample and fix merge bugs * Remove CryptoKeyManager class Co-authored-by: Thomas Norling <thomas.l.norling@gmail.com>
jo-arroyo
added a commit
that referenced
this pull request
Jan 20, 2023
Msal-common post release January 2023 patch #2
hectormmg
added a commit
that referenced
this pull request
Aug 18, 2023
hectormmg
added a commit
that referenced
this pull request
Oct 20, 2023
tnorling
added a commit
that referenced
this pull request
Mar 14, 2025
Splits up /authorize request generation into separate functions for 1. Standard params (included on all requests) 2. Browser auth code params 3. Node auth code params Note: #7633 adds another for Browser EAR Note2: Future (uncommitted) work to move /token and /logout to a similar pattern for extensibility and bundle size improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.