Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AzureAD/microsoft-authentication-library-for-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2e92cc718785548b24122b38c95fe62834bc90d0
Choose a base ref
...
head repository: AzureAD/microsoft-authentication-library-for-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 352f7410bbb7be130aef45d47bc739c560908449
Choose a head ref

Commits on Apr 3, 2023

  1. Bump pacakge versions

    hectormmg committed Apr 3, 2023
    Copy the full SHA
    c756a2e View commit details

Commits on Apr 4, 2023

  1. Update fabricbot.json to prompt for changefiles on msal-node-extensio…

    …ns changes (#5644)
    
    Updates Fabricbot config to comment on external msal-node-extensions PRs
    when changefiles are missing
    tnorling authored Apr 4, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    ca07f6f View commit details
  2. Update fabricbot.json to prompt for changefiles on msal-node-extensio…

    …ns changes (#5644)
    
    Updates Fabricbot config to comment on external msal-node-extensions PRs
    when changefiles are missing
    tnorling authored Apr 4, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2b908de View commit details
  3. Post-release April 2023 (#5850)

    This PR:
    
    Updates package-lock.json for recently published packages
    Updates CDN link and usage docs for MSAL Browser
    
    ---------
    
    Co-authored-by: Hector Morales <hemoral@microsoft.com>
    jo-arroyo and hectormmg authored Apr 4, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c4d8d22 View commit details
  4. Copy the full SHA
    35c1e48 View commit details

Commits on Apr 11, 2023

  1. Fix missing idToken in response after refresh (msal-browser v2) (#5870)

    Addresses bug #5863
    
    Same fix for msal-browser v3 in #5871
    tnorling authored Apr 11, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f25c339 View commit details
  2. Update beachball-check.yml

    tnorling authored Apr 11, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    de60140 View commit details

Commits on Apr 14, 2023

  1. Update beachball commands for LTS branch (#5877)

    Updates the branch on the LTS beachball commands
    tnorling authored Apr 14, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1791d04 View commit details
  2. Add temporaryCacheLocation to Cache Options (#5725)

    This is a PR follow up on [the issue we opened a few years
    ago](#4231).
    
    So in summary, we added a new property to the `CacheOptions` to make the
    temporary cache storage location configurable. It defaults to the
    existing cache storage location so it doesn't break anything when not
    configured.
    
    ---------
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: Thomas Norling <thomas.l.norling@gmail.com>
    Co-authored-by: Sameera Gajjarapu <sameera.gajjarapu@microsoft.com>
    Co-authored-by: Jo Arroyo <joarroyo@microsoft.com>
    Co-authored-by: Hector Morales <hemoral@microsoft.com>
    Co-authored-by: Shane Oatman <shoatman@microsoft.com>
    Co-authored-by: konstantin-msft <119362382+konstantin-msft@users.noreply.github.com>
    Co-authored-by: Konstantin Shabelko <kshabelko@microsoft.com>
    Co-authored-by: Robbie-Microsoft <87724641+Robbie-Microsoft@users.noreply.github.com>
    Co-authored-by: Robert Ginsburg <rgins16@gmail.com>
    Co-authored-by: Thomas Norling <thnorlin@microsoft.com>
    Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
    Co-authored-by: Lalima Sharda <lalima.sharda@gmail.com>
    Co-authored-by: Lalima Sharda <lalimasharda@microsoft.com>
    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: konstantin-msft <konstantin-msft@users.noreply.github.com>
    Co-authored-by: Salman Salem <v-ssalem@microsoft.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: tnorling <tnorling@users.noreply.github.com>
    19 people authored Apr 14, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    4f8de29 View commit details

Commits on Apr 17, 2023

  1. Unit tests for NativeBrokerPlugin (msal-node-extensions) (#5855)

    - Adds unit tests for the NativeBrokerPlugin implementation in
    msal-node-extensions
    - Fixes incorrect expiresOn property
    tnorling authored Apr 17, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    b7e8f3e View commit details
  2. Copy the full SHA
    5242132 View commit details
  3. Change files

    sameerag committed Apr 17, 2023
    Copy the full SHA
    9fc8ec7 View commit details

Commits on Apr 18, 2023

  1. Add CIAM authority support

    sameerag committed Apr 18, 2023
    Copy the full SHA
    9d21d1c View commit details
  2. Remove debug code

    sameerag committed Apr 18, 2023
    Copy the full SHA
    e4a8963 View commit details
  3. Update lib/msal-common/src/authority/Authority.ts

    Co-authored-by: Thomas Norling <thomas.l.norling@gmail.com>
    sameerag and tnorling committed Apr 18, 2023
    Copy the full SHA
    0bd872a View commit details
  4. Copy the full SHA
    1a61965 View commit details
  5. Copy the full SHA
    85a51fa View commit details
  6. Update lib/msal-common/src/authority/Authority.ts

    Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
    sameerag and Doğan Erişen committed Apr 18, 2023
    Copy the full SHA
    bcdb53d View commit details
  7. Update lib/msal-common/src/authority/Authority.ts

    Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
    sameerag and Doğan Erişen committed Apr 18, 2023
    Copy the full SHA
    3030cbb View commit details
  8. Update lib/msal-common/src/authority/Authority.ts

    Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
    sameerag and Doğan Erişen committed Apr 18, 2023
    Copy the full SHA
    854df00 View commit details
  9. Change files

    sameerag committed Apr 18, 2023
    Copy the full SHA
    4ba37f4 View commit details
  10. Copy the full SHA
    02b1ea6 View commit details
  11. Add docs for CIAM

    sameerag committed Apr 18, 2023
    Copy the full SHA
    47b8f35 View commit details
  12. Copy the full SHA
    cef1466 View commit details
  13. Update samples/msal-browser-samples/VanillaJSTestApp2.0/app/ciam/inde…

    …x.html
    
    Co-authored-by: Doğan Erişen <v-derisen@microsoft.com>
    sameerag and Doğan Erişen committed Apr 18, 2023
    Copy the full SHA
    4ecfa77 View commit details
  14. Copy the full SHA
    9ef14b8 View commit details
  15. Copy the full SHA
    352f741 View commit details
Showing with 24,369 additions and 14,648 deletions.
  1. +15 −6 .github/fabricbot.json
  2. +1 −1 .github/workflows/beachball-check.yml
  3. +17 −0 build/CredScanSuppressions.json
  4. +3 −2 build/sdl-tasks.yml
  5. +7 −0 change/@azure-msal-browser-1d79412c-4720-4290-a9cd-03c71a135c9b.json
  6. +7 −0 change/@azure-msal-browser-25232dc8-c6d0-4238-ad59-1c1f3fcd1a7a.json
  7. +7 −0 change/@azure-msal-common-a6cd149b-e838-48ba-97c1-311f4c331875.json
  8. +7 −0 change/@azure-msal-common-e35749d6-9407-4604-ad0c-f18c41f8021f.json
  9. +7 −0 change/@azure-msal-node-extensions-327efce7-518e-4288-b7eb-89a8c299b670.json
  10. +7 −0 change/msal-dc1e9ed0-d320-43bb-9b1b-a916b82acb68.json
  11. +3 −0 extensions/msal-node-extensions/jest.config.js
  12. +22,020 −14,499 extensions/msal-node-extensions/package-lock.json
  13. +6 −3 extensions/msal-node-extensions/package.json
  14. +2 −2 extensions/msal-node-extensions/src/broker/NativeBrokerPlugin.ts
  15. +20 −0 extensions/msal-node-extensions/test/__mocks__/@azure/msal-node-runtime.js
  16. +1,320 −0 extensions/msal-node-extensions/test/broker/NativeBrokerPlugin.spec.ts
  17. +2 −2 extensions/msal-node-extensions/test/lock/CrossPlatformLock.spec.ts
  18. +1 −1 extensions/msal-node-extensions/test/persistence/FilePersistence.spec.ts
  19. +3 −3 extensions/msal-node-extensions/test/persistence/FilePersistenceWithDataProtection.spec.ts
  20. +1 −1 extensions/msal-node-extensions/test/persistence/PersistenceCachePlugin.spec.ts
  21. +2 −2 extensions/msal-node-extensions/test/persistence/PersistenceCreator.spec.ts
  22. +80 −0 extensions/msal-node-extensions/test/util/TestConstants.ts
  23. +18 −18 lib/msal-angular/package-lock.json
  24. +1 −1 lib/msal-browser/README.md
  25. +8 −1 lib/msal-browser/docs/caching.md
  26. +3 −1 lib/msal-browser/docs/cdn-usage.md
  27. +2 −0 lib/msal-browser/docs/configuration.md
  28. +9 −9 lib/msal-browser/package-lock.json
  29. +1 −0 lib/msal-browser/src/app/ClientApplication.ts
  30. +21 −17 lib/msal-browser/src/cache/BrowserCacheManager.ts
  31. +9 −4 lib/msal-browser/src/config/Configuration.ts
  32. +1 −0 lib/msal-browser/test/app/PublicClientApplication.spec.ts
  33. +617 −26 lib/msal-browser/test/cache/BrowserCacheManager.spec.ts
  34. +1 −0 lib/msal-browser/test/cache/TokenCache.spec.ts
  35. +1 −0 lib/msal-browser/test/interaction_client/RedirectClient.spec.ts
  36. +16 −0 lib/msal-common/docs/authority.md
  37. +2 −2 lib/msal-common/package-lock.json
  38. +44 −4 lib/msal-common/src/authority/Authority.ts
  39. +3 −1 lib/msal-common/src/authority/AuthorityFactory.ts
  40. +2 −1 lib/msal-common/src/authority/AuthorityType.ts
  41. +3 −8 lib/msal-common/src/utils/Constants.ts
  42. +36 −0 lib/msal-common/test/authority/AuthorityFactory.spec.ts
  43. +1 −1 lib/msal-core/src/utils/Constants.ts
  44. +2 −2 lib/msal-core/src/utils/RequestUtils.ts
  45. +9 −9 lib/msal-node/package-lock.json
  46. +18 −18 lib/msal-react/package-lock.json
  47. +3 −3 package.json
21 changes: 15 additions & 6 deletions .github/fabricbot.json
Original file line number Diff line number Diff line change
@@ -1045,12 +1045,21 @@
}
},
{
"name": "prMatchesPattern",
"parameters": {
"pathFilter": "**.md",
"exclude": [],
"matchRegex": "lib\\/.*\\/src\\/"
}
"operator": "or",
"operands": [
{
"name": "prMatchesPattern",
"parameters": {
"matchRegex": "lib\\/.*\\/src\\/"
}
},
{
"name": "prMatchesPattern",
"parameters": {
"matchRegex": "extensions\\/.*\\/src\\/"
}
}
]
}
]
},
2 changes: 1 addition & 1 deletion .github/workflows/beachball-check.yml
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ name: Beachball Check
on:
pull_request:
branches:
- dev
- msal-lts

concurrency:
group: beachball-${{github.ref}}
17 changes: 17 additions & 0 deletions build/CredScanSuppressions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"tool": "Credential Scanner",
"suppressions": [
{
"placeholder": ["Bearer Token123", "Bearer Token456", "Bearer Token3434", "Bearer RenewToken123", "Bearer RenewToken456", "Bearer RenewToken3434", "verySecret=", "secret-001", "12345678901234567890123456789012"],
"_justification": "This is the secret placeholder used by my team"
},
{
"file": "\\maintenance\\passport-azure-ad\\README.md",
"_justification": "Source-controlled documentation with non-functional credential for illustration purpose only"
},
{
"file": ["\\maintenance\\passport-azure-ad\\test\\resource\\private.pem", "\\maintenance\\passport-azure-ad\\test\\End_to_end_test\\oidc_jwe_test.js", "\\maintenance\\passport-azure-ad\\test\\Chai-passport_test\\oidc_hybrid_and_code_flow_test.js", "\\maintenance\\adal-node\\test\\util\\util.ts"],
"_justification": "Hard-coded non-functional credential for testing purposes only"
}
]
}
5 changes: 3 additions & 2 deletions build/sdl-tasks.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Steps to run security scan tasks

steps:
- task: securedevelopmentteam.vss-secure-development-tools.build-task-policheck.PoliCheck@1
- task: securedevelopmentteam.vss-secure-development-tools.build-task-policheck.PoliCheck@2
displayName: 'Run PoliCheck'
inputs:
targetType: F
@@ -15,8 +15,9 @@ steps:
inputs:
scanFolder: './'
debugMode: false
suppressionsFile: '$(Build.SourcesDirectory)/build/CredScanSuppressions.json'

- task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@1
- task: securedevelopmentteam.vss-secure-development-tools.build-task-postanalysis.PostAnalysis@2
displayName: 'Post Analysis'
inputs:
CredScan: false
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix missing idToken in response after refresh #5870",
"packageName": "@azure/msal-browser",
"email": "thomas.norling@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Add temporaryCacheLocation to Cache Options #5725",
"packageName": "@azure/msal-browser",
"email": "nicolas.zawada@gmail.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update polycheck version (#5901)",
"packageName": "@azure/msal-common",
"email": "sameera.gajjarapu@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Add CIAM Authority Support(#5865)",
"packageName": "@azure/msal-common",
"email": "sameera.gajjarapu@microsoft.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Update token expiry",
"packageName": "@azure/msal-node-extensions",
"email": "thomas.norling@microsoft.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/msal-dc1e9ed0-d320-43bb-9b1b-a916b82acb68.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update polycheck version, rename Blacklist params (#5901)",
"packageName": "msal",
"email": "sameera.gajjarapu@microsoft.com",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions extensions/msal-node-extensions/jest.config.js
Original file line number Diff line number Diff line change
@@ -4,5 +4,8 @@
*/

module.exports = {
preset: "ts-jest",
testEnvironment: "node",
collectCoverageFrom: ["src/**/*.ts"],
coverageReporters: [["lcov", {"projectRoot": "../../"}]]
};
Loading