Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken tests #410

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Update broken tests #410

merged 1 commit into from
Apr 18, 2023

Conversation

chlowell
Copy link
Collaborator

This updates tests to specify at least one scope (failing to do so became an error with #403). CI could be much more helpful in catching problems like this before PRs merge; see #393.

@chlowell chlowell added the bug Something isn't working label Apr 13, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chlowell chlowell marked this pull request as ready for review April 13, 2023 22:27
@bgavrilMS
Copy link
Member

@chlowell - I gave you admin access to the repo, please feel free to make any changes you see fit to the CI and to the release ceremony (but pls keep us in the loop)

@chlowell chlowell merged commit 6a16f64 into dev Apr 18, 2023
7 checks passed
@chlowell chlowell deleted the chlowell/test-fix branch April 18, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants