Remove unsupported tests (ADFS v2 v3, iOS, Android) #4422
Merged
+124
−1,206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
gladjohn,
neha-bhargava,
pmaytak and
trwalke
bgavrilMS
changed the title
|
@trwalke - please review the changes to the public lab API |
gladjohn
reviewed
Nov 18, 2023
tests/Microsoft.Identity.Test.Integration.netfx/HeadlessTests/OnBehalfOfTests.cs
Show resolved
Hide resolved
bgavrilMS
force-pushed
the
bogavril/adfs2012
branch
from
f1693dc to
8156eb5
Compare
pmaytak
approved these changes
Nov 20, 2023
tests/Microsoft.Identity.Test.Integration.netfx/HeadlessTests/ClientCredentialsTests.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netfx/HeadlessTests/OnBehalfOfTests.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netfx/Infrastructure/SeleniumExtensions.cs
Show resolved
Hide resolved
trwalke
reviewed
Nov 30, 2023
| public static Task<LabResponse> GetDefaultUserAsync() | ||
| { | ||
| return GetLabUserDataAsync(UserQuery.PublicAadUserQuery); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Returns the AAD cloud user idlab2@msidlab4.onmicrosoft.com |
There was a problem hiding this comment.
The user referenced in PublicAadUser2Query is actually idlab@msidlab4.onmicrosoft.com
trwalke
reviewed
Nov 30, 2023
|
2 minor comments, LGTM otherwise |
trwalke
approved these changes
Nov 30, 2023
bgavrilMS
force-pushed
the
bogavril/adfs2012
branch
from
097e9d0 to
9b01dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADFSv2 and ADFSv3 are now out of support.