Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API for managed identity #4107

Merged
merged 18 commits into from
May 9, 2023
Merged

Update API for managed identity #4107

merged 18 commits into from
May 9, 2023

Conversation

neha-bhargava
Copy link
Contributor

@neha-bhargava neha-bhargava commented Apr 26, 2023 •
edited

Fixes #4114

Changes proposed in this request

  • Update managed identity api to specify managed identity with .Create() method.
  • Remove cache extensibility APIs from managed identity builder.

Testing
Update unit and integration tests

Performance impact

Documentation

  • All relevant documentation is updated.

@neha-bhargava neha-bhargava marked this pull request as ready for review April 27, 2023 18:57
bgavrilMS
bgavrilMS requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use object instead of interface. See comment.

@neha-bhargava neha-bhargava linked an issue May 2, 2023 that may be closed by this pull request
Update managed identity API to specify the identity when creating the application. #4114
Closed
pmaytak
pmaytak reviewed May 3, 2023
View reviewed changes
src/client/Microsoft.Identity.Client/AppConfig/ManagedIdentityIdType.cs Show resolved Hide resolved
tests/Microsoft.Identity.Test.Integration.netfx/HeadlessTests/ManagedIdentityTests.cs Show resolved Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ManagedIdentityApplicationBuilder.cs Outdated Show resolved Hide resolved
tests/Microsoft.Identity.Test.Common/TestConstants.cs Outdated Show resolved Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ManagedIdentityConfiguration.cs Outdated Show resolved Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ManagedIdentityApplicationBuilder.cs Outdated Show resolved Hide resolved
src/client/Microsoft.Identity.Client/AppConfig/ManagedIdentityApplicationOptions.cs Outdated Show resolved Hide resolved
pmaytak
pmaytak approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just rename ManagedIdentityConfiguration to ManagedIdentityId.

gladjohn
gladjohn approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@gladjohn gladjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Neha

@neha-bhargava neha-bhargava merged commit e7533b0 into main May 9, 2023
8 checks passed
@neha-bhargava neha-bhargava deleted the nebharg/ApiUpdates branch May 9, 2023 17:35
@tompazourek tompazourek mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayluo rayluo rayluo left review comments

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@trwalke trwalke trwalke left review comments

@siddhijain siddhijain siddhijain left review comments

@pmaytak pmaytak pmaytak approved these changes

@gladjohn gladjohn gladjohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update managed identity API to specify the identity when creating the application.
7 participants
@neha-bhargava @rayluo @bgavrilMS @trwalke @siddhijain @pmaytak @gladjohn