Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback from WAM to browser on B2C, extend Webview2 support #4073

Merged
merged 14 commits into from
Apr 14, 2023

Conversation

bgavrilMS
Copy link
Member

@bgavrilMS bgavrilMS commented Apr 13, 2023

Fixes #4072

Changes proposed in this request

  • Disallow WAM on non-AAD (e.g. B2C)
  • Allow webview2 on ADFS
  • New API for adding WV2 support from MSAL.Desktop

Testing

Performance impact

Documentation

  • All relevant documentation is updated.

Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should update this error message to

                throw new MsalClientException(MsalError.WebviewUnavailable,
                    "If you have a Windows application which targets net5.0 or above, change the target to at least net6.0-windows, " +
                        "which provides support from Windows 7 to Windows 10. For details, see https://github.com/dotnet/designs/blob/main/accepted/2020/platform-checks/platform-checks.md" +

                    "If you have a cross-platform (Windows, Mac, Linux) application which targets net6.0, dual target net6.0 and net6.0-windows." +
                        "Your installer should deploy the net6.0 version on Mac and Linux and the net6.0-window on Windows." +
                        "For details, see https://github.com/dotnet/designs/blob/main/accepted/2020/platform-checks/platform-checks.md" +

                    "If you have a .NET Core 3.1 app, reference the NuGet package Microsoft.Identity.Client.Desktop and call the extension method .AddEmbeddedBrowserSupport() first." + "For details, see https://aka.ms/msal-net-webview2 or use the system WebView - see https://aka.ms/msal-net-os-browser");

@bgavrilMS bgavrilMS merged commit 0c8cb9c into main Apr 14, 2023
8 checks passed
@bgavrilMS bgavrilMS deleted the bogavril/4072 branch April 14, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] WAM is invoked for B2C authorities and MSAL.Desktop API is not good for B2C
5 participants