-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback from WAM to browser on B2C, extend Webview2 support #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
commented
Apr 13, 2023
src/client/Microsoft.Identity.Client.Desktop/DesktopExtensions.cs
Outdated
Show resolved
Hide resolved
neha-bhargava
approved these changes
Apr 13, 2023
gladjohn
reviewed
Apr 13, 2023
src/client/Microsoft.Identity.Client/Platforms/Features/RuntimeBroker/RuntimeBroker.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/WebUITests/WebView2WebUiFactoryTests.cs
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/WebUITests/WebView2WebUiFactoryTests.cs
Show resolved
Hide resolved
gladjohn
approved these changes
Apr 13, 2023
gladjohn
reviewed
Apr 13, 2023
src/client/Microsoft.Identity.Client.Desktop/DesktopExtensions.cs
Outdated
Show resolved
Hide resolved
trwalke
approved these changes
Apr 13, 2023
bgavrilMS
force-pushed
the
bogavril/4072
branch
from
April 13, 2023 23:22
6892e47
to
a02a911
Compare
pmaytak
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also should update this error message to
throw new MsalClientException(MsalError.WebviewUnavailable,
"If you have a Windows application which targets net5.0 or above, change the target to at least net6.0-windows, " +
"which provides support from Windows 7 to Windows 10. For details, see https://github.com/dotnet/designs/blob/main/accepted/2020/platform-checks/platform-checks.md" +
"If you have a cross-platform (Windows, Mac, Linux) application which targets net6.0, dual target net6.0 and net6.0-windows." +
"Your installer should deploy the net6.0 version on Mac and Linux and the net6.0-window on Windows." +
"For details, see https://github.com/dotnet/designs/blob/main/accepted/2020/platform-checks/platform-checks.md" +
"If you have a .NET Core 3.1 app, reference the NuGet package Microsoft.Identity.Client.Desktop and call the extension method .AddEmbeddedBrowserSupport() first." + "For details, see https://aka.ms/msal-net-webview2 or use the system WebView - see https://aka.ms/msal-net-os-browser");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4072
Changes proposed in this request
Testing
Performance impact
Documentation