[WAM] Adding more dev apps to test msalruntime existence #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
reviewed
Apr 7, 2023
| @@ -28,6 +28,14 @@ steps: | |||
| custom: 'workload' | |||
| arguments: 'restore .\src\client\Microsoft.Identity.Client\Microsoft.Identity.Client.csproj' | |||
|
|
|||
| - task: Bash@3 | |||
| displayName: Install MAUI | |||
There was a problem hiding this comment.
This task adds ~6 minutes to the build time. Wondering if we can move these WAM devapps in to a separate sln, which we build and run these tests on?
It's ok for now to improve the tests. Just trying to be mindful each time we update the build pipeline to make sure we don't get into situation again when we have to refactor the pipeline since our builds take long time again.
Comment on lines
+36
to
+37
| dotnet workload install maui --source https://aka.ms/dotnet6/nuget/index.json --source https://api.nuget.org/v3/index.json | ||
| dotnet workload install android ios maccatalyst tvos macos maui wasm-tools --source https://aka.ms/dotnet6/nuget/index.json --source https://api.nuget.org/v3/index.json |
There was a problem hiding this comment.
nit: we don't need to install all these workloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more dev apps to test msalruntime existence
this PR adds the following dev apps
runtimeidentifiers