Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert configuration manager to 8.3.1 #3132

Merged
merged 14 commits into from
Feb 14, 2025
Merged

Revert configuration manager to 8.3.1 #3132

merged 14 commits into from
Feb 14, 2025
+264 −994

Conversation

keegan-caruso
Copy link
Contributor

Reverts configuration manager back to 8.3.1, and cherry picks #3022

Compare configuration manager against 8.3.1 with this diff: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/rel/8.3.1...kecaruso/revert-config-man-changes?expand=1

Only includes changes for #3022

Keegan Caruso and others added 7 commits February 13, 2025 16:55
Revert "App context switch to allow blocking or non-blocking GetConfi…
Loading
Loading status checks…
9ac0e21 
…guration (#3106)"

This reverts commit f56ea16.
Revert "Add additional condition before requesting update. (#3095)"
Loading
Loading status checks…
1801cf4 
This reverts commit 0108a96.
Revert "Add request count and duration telemetry (#3022)"
2389294 
This reverts commit 9e91a64.
Revert "Make updates to syncAfter and lastRefreshRequest atomic (#3090)"
809c090 
This reverts commit 075a627.
Revert "RequestRefresh back to a signal for GetConfigurationAsync (#3087
ad9bb20 
)"

This reverts commit 42b0c2c.
Revert "Revert change to make RequestRefresh run in the background (#…
db55b8c 
…3083)"

This reverts commit 3f2fbf1.
@westin-m @GeoK
@jennyf19 @keegan-caruso
Add request count and duration telemetry (#3022)
9173f91 
* Add request count and duration telemetry

* Add request count and duration telemetry

* small fix

* Feedback, remodel timing and counters

* Use interface for logging, move constants to class

* some interface changes, rework tests

* fix naming

* address interface feedback

* Interface and namespace changes

* avoid friend assemblies

* add metadata

* doc comments for tags

* PR feedback

* Apply suggestions from code review

Co-authored-by: Keegan <Keegan.Caruso@microsoft.com>

* change class name and add clarifying comments

* Change namespace, move package reference

---------

Co-authored-by: George Krechar <dokrecar@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: Keegan <Keegan.Caruso@microsoft.com>
@keegan-caruso keegan-caruso requested a review from a team as a code owner February 14, 2025 01:37
jennyf19
jennyf19 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/14/2025 - 5:54:56 PM
Coverage date: 2/14/2025 - 5:44:36 PM - 2/14/2025 - 5:54:31 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@keegan-caruso keegan-caruso force-pushed the kecaruso/revert-config-man-changes branch from 6eded55 to d8cdcfb Compare February 14, 2025 20:55
@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/14/2025 - 9:09:33 PM
Coverage date: 2/14/2025 - 9:00:04 PM - 2/14/2025 - 9:09:08 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@jennyf19 jennyf19 mentioned this pull request Feb 14, 2025
Closed
@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 2/14/2025 - 10:49:54 PM
Coverage date: 2/14/2025 - 10:39:58 PM - 2/14/2025 - 10:49:28 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@keegan-caruso keegan-caruso merged commit 414bf24 into dev Feb 14, 2025
6 checks passed
@pmaytak pmaytak added this to the 8.5.0 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoK GeoK

@jennyf19 jennyf19

@pmaytak pmaytak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keegan-caruso @GeoK @jennyf19 @pmaytak @westin-m