Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling fixes #3117

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Spelling fixes #3117

merged 1 commit into from
Feb 5, 2025
+6 −6

Conversation

westin-m
Copy link
Contributor

@westin-m westin-m commented Feb 5, 2025

Address all spelling errors caught by the spell checker in VS

@westin-m
spelling fixes
Loading
Loading status checks…
73cb48d
@westin-m westin-m requested a review from a team as a code owner February 5, 2025 22:16
@westin-m westin-m linked an issue Feb 5, 2025 that may be closed by this pull request
Fix spelling mistakes #3118
Closed
@westin-m westin-m added this to the 8.3.2 milestone Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Summary

Summary
Generated on: 2/5/2025 - 10:29:36 PM
Coverage date: 2/5/2025 - 10:19:16 PM - 2/5/2025 - 10:29:07 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@westin-m westin-m merged commit c21a944 into dev Feb 5, 2025
6 checks passed
@westin-m westin-m deleted the westin/spelling branch February 5, 2025 22:41
pmaytak
pmaytak reviewed Feb 5, 2025
View reviewed changes
src/Microsoft.IdentityModel.Tokens/RsaSecurityKey.cs
}

internal void IntializeWithRsaParameters(RSAParameters rsaParameters)
internal void InitializeWithRsaParameters(RSAParameters rsaParameters)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westin-m Shouldn't this change have triggered the public API analyzer?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot take any spelling changes if they impact the public API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a similar thought, but this is internal. I double checked SAL and MISE and there aren't usages of this through friend assemblies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19

@pmaytak pmaytak

@kllysng kllysng

@keegan-caruso keegan-caruso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

Fix spelling mistakes
5 participants
@westin-m @jennyf19 @pmaytak @keegan-caruso @kllysng