Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request count and duration telemetry #3022

Merged
merged 27 commits into from
Jan 15, 2025
Merged

Add request count and duration telemetry #3022

merged 27 commits into from
Jan 15, 2025
+708 −8

Conversation

westin-m
Copy link
Contributor

@westin-m westin-m commented Nov 20, 2024 •
edited
Loading

Addresses client telemetry repair item

Add counter for get configuration requests and histogram for total duration of the same requests.

@westin-m
Add request count and duration telemetry
Loading
Loading status checks…
c5e5d91
@westin-m westin-m linked an issue Nov 20, 2024 that may be closed by this pull request
Add metadata request time to client telemetry #3023
Closed
@westin-m westin-m marked this pull request as ready for review November 21, 2024 23:05
@westin-m westin-m requested a review from a team as a code owner November 21, 2024 23:05
@westin-m westin-m changed the title Add request count and duration telemetry DRAFT Add request count and duration telemetry Nov 21, 2024
GeoK
GeoK reviewed Nov 22, 2024
View reviewed changes
keegan-caruso
keegan-caruso reviewed Nov 23, 2024
View reviewed changes
brentschmaltz
brentschmaltz requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking for layering changes.

brentschmaltz
brentschmaltz requested changes Dec 21, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some naming.
Code should live in assembly where dependencies are included.
Why do we need an interface?

pmaytak
pmaytak reviewed Dec 28, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Summary

Summary
Generated on: 1/6/2025 - 9:00:11 PM
Coverage date: 1/6/2025 - 8:50:27 PM - 1/6/2025 - 8:59:44 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@AzureAD AzureAD deleted a comment from github-actions bot Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 4:38:06 PM
Coverage date: 1/7/2025 - 4:28:47 PM - 1/7/2025 - 4:37:40 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@westin-m @keegan-caruso
Apply suggestions from code review
a7f85cf 
Co-authored-by: Keegan <Keegan.Caruso@microsoft.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 9:17:22 PM
Coverage date: 1/7/2025 - 9:08:15 PM - 1/7/2025 - 9:16:57 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Summary

Summary
Generated on: 1/7/2025 - 10:12:44 PM
Coverage date: 1/7/2025 - 10:02:50 PM - 1/7/2025 - 10:12:17 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

brentschmaltz
brentschmaltz requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest putting telemetry code in M.IM.Logging assembly.

@github-actions GitHub Actions
Copy link

Summary

Summary
Generated on: 1/14/2025 - 11:57:10 PM
Coverage date: 1/14/2025 - 11:47:21 PM - 1/14/2025 - 11:56:45 PM
Parser: MultiReport (60x Cobertura)
Assemblies: 1
Classes: 7
Files: 2
Line coverage: 80.3% (620 of 772)
Covered lines: 620
Uncovered lines: 152
Coverable lines: 772
Total lines: 483
Branch coverage: 67.8% (228 of 336)
Covered branches: 228
Total branches: 336
Method coverage: Feature is only available for sponsors

Coverage

Microsoft.IdentityModel.JsonWebTokens - 80.3%
Name Line Branch
Microsoft.IdentityModel.JsonWebTokens 80.3% 67.8%
Microsoft.IdentityModel.JsonWebTokens.JwtTokenUtilities 100%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated 80.3% 67.8%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F12A1AEDDDFE32BA
DF4DBFF323AF1BCB48B9F9721B7CD3E05F5E034CF225E3DF8__CreateJwsRegex_0		 81.4% 67.6%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJweRegex_1		 79.2% 68%
System.Text.RegularExpressions.Generated.<RegexGenerator_g>F334844C618E00D3
CEC5D3FE0D00CF0141BBEE98635313BB2CB8D3921464CE05A__CreateJwsRegex_0		 81.4% 67.6%

@westin-m westin-m merged commit 9e91a64 into dev Jan 15, 2025
6 checks passed
@westin-m westin-m deleted the westin/clientTelemetry branch January 15, 2025 01:01
keegan-caruso pushed a commit that referenced this pull request Feb 14, 2025
Revert "Add request count and duration telemetry (#3022)"
2389294 
This reverts commit 9e91a64.
keegan-caruso added a commit that referenced this pull request Feb 14, 2025
@westin-m @GeoK
@jennyf19 @keegan-caruso
Add request count and duration telemetry (#3022)
9173f91 
* Add request count and duration telemetry

* Add request count and duration telemetry

* small fix

* Feedback, remodel timing and counters

* Use interface for logging, move constants to class

* some interface changes, rework tests

* fix naming

* address interface feedback

* Interface and namespace changes

* avoid friend assemblies

* add metadata

* doc comments for tags

* PR feedback

* Apply suggestions from code review

Co-authored-by: Keegan <Keegan.Caruso@microsoft.com>

* change class name and add clarifying comments

* Change namespace, move package reference

---------

Co-authored-by: George Krechar <dokrecar@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: Keegan <Keegan.Caruso@microsoft.com>
@keegan-caruso keegan-caruso mentioned this pull request Feb 14, 2025
Merged
@pmaytak pmaytak modified the milestone: 8.5.0 Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaytak pmaytak

@keegan-caruso keegan-caruso

Copilot code review Copilot

@GeoK GeoK

@brentschmaltz brentschmaltz

Assignees
No one assigned
Labels
repair item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metadata request time to client telemetry
7 participants
@westin-m @skblr2022 @GeoK @brentschmaltz @pmaytak @keegan-caruso @jennyf19