Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Log Scrubbing] Clean up log messages in Wilson #2339

Merged
merged 4 commits into from
Oct 2, 2023
Merged

[Log Scrubbing] Clean up log messages in Wilson #2339

merged 4 commits into from
Oct 2, 2023

Conversation

TimHannMSFT
Copy link
Contributor

[Log Scrubbing] Clean up log messages in Wilson

Description

  • Fixing up logging messages in Wilson
  • Adding unit tests for some logging methods

@TimHannMSFT
Copy link
Contributor Author

@keegan-caruso raised a good point offline, this will be cherry picked into Wilson 7 once completed.

keegan-caruso
keegan-caruso approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor nits, LGTM

@TimHannMSFT
Copy link
Contributor Author

@keegan-caruso raised a good point offline, this will be cherry picked into Wilson 7 once completed.

My knowledge is out of date, dev is Wilson 7 now, should be cherry picked into dev6x

henrik-me
henrik-me approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jennyf19
jennyf19 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TimHannMSFT TimHannMSFT merged commit b0fadfe into dev Oct 2, 2023
5 checks passed
@TimHannMSFT TimHannMSFT deleted the timhann/logScrubbing branch October 2, 2023 22:08
TimHannMSFT added a commit that referenced this pull request Oct 2, 2023
@TimHannMSFT
[Log Scrubbing] Clean up log messages in Wilson (#2339)
b9857bd 
* [Log Scrubbing] Clean up log messages in Wilson

* Fix spelling nit and clarify collection use in comment

* address PR feedback on spelling and input validation

* addressing naming feedback
TimHannMSFT added a commit that referenced this pull request Oct 3, 2023
@TimHannMSFT
[Log Scrubbing] Clean up log messages in Wilson (#2339) (#2344)
9d9925e 
[Log Scrubbing] Clean up log messages in Wilson (#2339)



* Update code to fix build breaks between dev and dev6x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentschmaltz brentschmaltz brentschmaltz left review comments

@jennyf19 jennyf19 jennyf19 approved these changes

@henrik-me henrik-me henrik-me approved these changes

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@ciaozhang ciaozhang Awaiting requested review from ciaozhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TimHannMSFT @brentschmaltz @jennyf19 @henrik-me @keegan-caruso