bugfix: skip setting empty tags in request body #466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #462
In the following function, to suppress the diff of config: tags = null and state: tags = {}, it'll set plan.tags to {} even if it's not defined in config when upgrading from previous provider.
And this will fail the schema validation if the resource doesn't support "tags". And bypassing the validation won't mitigate this, because the empty tags will be set in the request body and user will get a bad request error.
The fix is adding tags to the request body only if it's not empty.
terraform-provider-azapi/internal/services/azapi_resource.go
Lines 858 to 880 in 192e61b