Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completion enhancements #586

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Conversation

albers
Copy link
Contributor

@albers albers commented Dec 27, 2024

This PR features several enhancements to shell completion:

  • no filename completion after command names, e.g. kubelogin get-token <TAB><TAB>
  • completion for get-token --login, see Improve shell completion for convert-config #582
  • completion for kubelogin convert-kubeconfig --context
  • only flags that take filenames or dirnames have file or dirname completion

For hints on how to verify, see #582

@albers
Copy link
Contributor Author

albers commented Jan 5, 2025

The CI error seems unrelated to me, can someone please take a look?

@weinong
Copy link
Contributor

weinong commented Jan 7, 2025

@albers can you rebase please? I made some changes to drop the manual codeql.

@albers albers force-pushed the completion-enhancements branch from ee21430 to 5952afa Compare January 7, 2025 08:21
@albers
Copy link
Contributor Author

albers commented Jan 7, 2025

@weinong Thanks, done.

Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit 2cd42fb into Azure:main Jan 7, 2025
4 checks passed
@albers albers deleted the completion-enhancements branch January 8, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants