Stop retriable request from adding a non-nil Body #726
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When azure is responding with an error the retriable request that is generated ends up getting a non nil noOpcloser added to it with a reader interface. Ultimately this ends up sending a GET request to Azure that has a post body. As the http spec says that the body SHOULD be ignored this is not a critical error, but for people using custom transports this is problematic. It's also sending unnecessary bytes.
Example of the request being sent with an initial request:
Body:{} GetBody:<nil>
This is the body when the same request is then retried:
Body:{Reader:} GetBody:<nil>
I attempted to write a test for this but it turns out much of the test suite is leveraging GET with bodies in them. Inserting an error into the mocks for GET's with non-nil and non-empty request bodies broke a number of assumptions within the test framework. So I didn't end up adding an explicit test for this situation. The test suite does cover these lines already with unit tests to some degree and they are all still passing. I verified this locally with manual testing to confirm that
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions: