Azure Identity: AzureCliCredentials and AzureDeveloperCliCredential handle stderr may be None when executing subprocess #39176
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
requested review from
pvaneck,
xiangyan99 and
a team
as code owners
jenshnielsen
requested review from
joshfree,
billwert,
ahsonkhan,
KarishmaGhiya and
scottaddie
github-actions
bot
added
Azure.Identity
Community Contribution
|
Thank you for your contribution @jenshnielsen! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
jenshnielsen
force-pushed
the
azure_identity_handle_stderr_none
branch
from
fd69b67 to
92ab2e9
Compare
jenshnielsen
changed the title
for AzureCliCredential According to the docs CredentialUnavailableError.stderr may be None if no output is captured. ``` Stderr output of the child process if it was captured by run(). Otherwise, None. ``` https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError In AzureCliCredential._run_command this is handled when propergating the error but was overlooked in other parts of the code. This pr fixes the code to ensure that the None case is handled before checking for str content.
add a test for error handling when AzureDeveloperCliCredential fails to capture stderr
for AzureDeveloperCliCredential According to the docs CredentialUnavailableError.stderr may be None if no output is captured. ``` Stderr output of the child process if it was captured by run(). Otherwise, None. ``` https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError In _run_command this is handled when propergating the error but was overlooked in other parts of the code. This pr fixes the code to ensure that the None case is handled before checking for str content.
add a test for error handling when AzureCliCredential execution fails to capture stderr
jenshnielsen
force-pushed
the
azure_identity_handle_stderr_none
branch
from
92ab2e9 to
9ff3a7c
Compare
jenshnielsen
commented
Jan 14, 2025
jenshnielsen
force-pushed
the
azure_identity_handle_stderr_none
branch
from
c27a12c to
9568ced
Compare
xiangyan99
approved these changes
Jan 16, 2025
allenkim0129
pushed a commit
to allenkim0129/azure-sdk-for-python
that referenced
this pull request
Jan 27, 2025
…andle stderr may be None when executing subprocess (Azure#39176) * Azure Identity: Handle stderr may be None for AzureCliCredential According to the docs CredentialUnavailableError.stderr may be None if no output is captured. ``` Stderr output of the child process if it was captured by run(). Otherwise, None. ``` https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError In AzureCliCredential._run_command this is handled when propergating the error but was overlooked in other parts of the code. This pr fixes the code to ensure that the None case is handled before checking for str content. * AzureIdentity: AzureDeveloperCliCredential add a test for error handling when AzureDeveloperCliCredential fails to capture stderr * Azure Identity: Handle stderr may be None for AzureDeveloperCliCredential According to the docs CredentialUnavailableError.stderr may be None if no output is captured. ``` Stderr output of the child process if it was captured by run(). Otherwise, None. ``` https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError In _run_command this is handled when propergating the error but was overlooked in other parts of the code. This pr fixes the code to ensure that the None case is handled before checking for str content. * AzureIdentity: AzureCliCredential add a test for error handling when AzureCliCredential execution fails to capture stderr * Add changelog for 39176
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
…andle stderr may be None when executing subprocess (Azure#39176) * Azure Identity: Handle stderr may be None for AzureCliCredential According to the docs CredentialUnavailableError.stderr may be None if no output is captured. ``` Stderr output of the child process if it was captured by run(). Otherwise, None. ``` https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError In AzureCliCredential._run_command this is handled when propergating the error but was overlooked in other parts of the code. This pr fixes the code to ensure that the None case is handled before checking for str content. * AzureIdentity: AzureDeveloperCliCredential add a test for error handling when AzureDeveloperCliCredential fails to capture stderr * Azure Identity: Handle stderr may be None for AzureDeveloperCliCredential According to the docs CredentialUnavailableError.stderr may be None if no output is captured. ``` Stderr output of the child process if it was captured by run(). Otherwise, None. ``` https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError In _run_command this is handled when propergating the error but was overlooked in other parts of the code. This pr fixes the code to ensure that the None case is handled before checking for str content. * AzureIdentity: AzureCliCredential add a test for error handling when AzureCliCredential execution fails to capture stderr * Add changelog for 39176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the docs
CredentialUnavailableError.stderr may be None
if no output is captured.
https://docs.python.org/3/library/subprocess.html#subprocess.CalledProcessError
In AzureCliCredential._run_command (and similar in AzureDeveloperCliCredential) this is
handled when propagating the error
but was overlooked in other parts of the code.
This pr fixes the code to ensure that the None
case is handled before checking for str content.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines