Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Add subscription support to Azure CLI cred #37994

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Oct 18, 2024

Closes: #33129

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck force-pushed the identity-cli-support-subscription branch from c35a2b7 to fcf022e Compare October 21, 2024 20:49
@pvaneck pvaneck marked this pull request as ready for review October 22, 2024 18:04
@pvaneck pvaneck requested review from xiangyan99 and a team as code owners October 22, 2024 18:04
@xiangyan99
Copy link
Member

Are other languages supporting it? (other than go)

@pvaneck
Copy link
Member Author

pvaneck commented Oct 22, 2024

Are other languages supporting it? (other than go)

All languages will support it at some point, and JS already added support.

@xiangyan99
Copy link
Member

Are other languages supporting it? (other than go)

All languages will support it at some point, and JS already added support.

Do we have a design doc for the feature?

e.g. do we only support it in init? Do we want to support it in get_token()?

@xiangyan99
Copy link
Member

And do we want to expose it in DAC init?

@pvaneck
Copy link
Member Author

pvaneck commented Oct 23, 2024

Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the changelog.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck merged commit 323609b into Azure:main Oct 24, 2024
21 checks passed
@pvaneck pvaneck deleted the identity-cli-support-subscription branch October 24, 2024 00:09
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
This allows users to specify a subscription when authenticating with the Azure CLI.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Add Subscription option for Azure CLI credential
3 participants