Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove promptflow-azure dependency #38719

Merged
merged 44 commits into from
Dec 3, 2024

Conversation

ralph-msft
Copy link
Member

  • Removes the optional [remote] for azure-ai-evaluation. The azure-ai-datastore dependency is now part of the base requirements
  • Replaces the promptflow-azure dependency with a lite Azure management client
    • Brings over the bare minimum JSON deserialization models from azure-ai-ml
    • Adds a new AzureManagementAPITokenManager to manage credentials and tokens in a way similar to promptflow-azure
  • TestMetricsUpload integration test playback from recordings is now working
  • Added integration tests for the lite Azure management client
  • Fixed some typos in some test code
  • Addressed linter warnings

@ralph-msft ralph-msft self-assigned this Nov 27, 2024
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Nov 27, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 27, 2024

API change check

API changes are not detected in this pull request.

@ralph-msft ralph-msft marked this pull request as ready for review December 2, 2024 21:39
@ralph-msft ralph-msft requested a review from a team as a code owner December 2, 2024 21:39
@ralph-msft ralph-msft enabled auto-merge (squash) December 2, 2024 21:40
```
\n     request: \"number\":0}\n\"
```
vs
```
\n     record:  \"number\":0}\r\n\"
```
@ralph-msft ralph-msft merged commit 1b3c546 into Azure:main Dec 3, 2024
20 checks passed
@ralph-msft ralph-msft deleted the ralphe/remove_pf_azure_dependency branch December 3, 2024 22:18
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
- Removes the optional [remote] for azure-ai-evaluation. The azure-ai-datastore dependency is now part of the base requirements
- Replaces the promptflow-azure dependency with a lite Azure management client
  - Brings over the bare minimum JSON deserialization models from azure-ai-ml
  - Adds a new AzureManagementAPITokenManager to manage credentials and tokens in a way similar to promptflow-azure
- TestMetricsUpload integration test playback from recordings is now working
- Added integration tests for the lite Azure management client
- Fixed some typos in some test code
- Addressed linter warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants