[Identity] Adjust tests to reduce flakiness #38712
Merged
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the managed identity unit tests rely on time.time(), and this can cause some assertions to be off by one, causing flakiness in tests. This adds some leeway to the comparison. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
|
API change check API changes are not detected in this pull request. |
pvaneck
requested review from
christothes,
billwert,
g2vinay,
ahsonkhan,
chlowell and
mpodwysocki
xiangyan99
approved these changes
Dec 3, 2024
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
Some of the managed identity unit tests rely on time.time(), and this can cause some assertions to be off by one, causing flakiness in tests. This adds some leeway to the comparison. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the managed identity unit tests rely on time.time(), and this can cause some assertions to be off by one, causing flakiness in tests. This adds some leeway to the comparison.
Example error: