[Monitor Query] Typing updates #35180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pvaneck
force-pushed
the
query-next-typing
branch
2 times, most recently
from
995d0a3
to
adea84f
Compare
pvaneck
requested review from
sarangan12,
gracewilcox,
srnagar,
ToddKingMSFT,
jairmyree,
nisha-bhatia,
gulopesd and
kristapratico
pvaneck
force-pushed
the
query-next-typing
branch
2 times, most recently
from
08a67b3
to
eabc300
Compare
Regenerated with latest autorest and updated some samples. Adjusted samples to be more type-complete by adding `isinstance` checks for responses that are Unions. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
query-next-typing
branch
from
eabc300
to
b5feab3
Compare
sdk/monitor/azure-monitor-query/azure/monitor/query/_exceptions.py
Outdated
Show resolved
Hide resolved
sdk/monitor/azure-monitor-query/samples/async_samples/sample_batch_query_async.py
Show resolved
Hide resolved
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
kristapratico
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated with latest autorest and updated some samples.
Changed the model types for
statusto use Literal with the corresponding enum values to improve typing.Closes: #32377, #32379