Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose new models #35027

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Expose new models #35027

merged 1 commit into from
Apr 1, 2024

Conversation

xiangyan99
Copy link
Member

@xiangyan99 xiangyan99 commented Apr 1, 2024 •
edited

@github-actions github-actions bot added the Search label Apr 1, 2024
@xiangyan99 xiangyan99 marked this pull request as ready for review April 1, 2024 18:34
@xiangyan99 xiangyan99 requested a review from pvaneck April 1, 2024 18:34
pvaneck
pvaneck approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the pipeline didn't generate a new ApiView revision here, but I'm assuming it should be created from the internal pipeline since there are several API additions.

@xiangyan99 xiangyan99 merged commit 4901ba0 into main Apr 1, 2024
19 checks passed
@xiangyan99 xiangyan99 deleted the search_expose_models branch April 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvaneck pvaneck pvaneck approved these changes

Assignees
No one assigned
Labels
Search
Projects
Azure SDK for Search
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiangyan99 @pvaneck