Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SchemaRegistry] add avroserializer package back for deprecation #31667

Merged

Conversation

swathipil
Copy link
Member

Adding back the azure-schemaregistry-avroserializer package for deprecation and documentation purposes.

Related to: #23057

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this. We probably should add the artifact to the artifact list in schemaregistry/ci.yml, but frankly it doesn't really matter as this won't release successfully anyway due to the .post1 version suffix.

@swathipil swathipil enabled auto-merge (squash) August 18, 2023 15:24
@scbedd
Copy link
Member

scbedd commented Aug 18, 2023

Well I wasn't expecting that failure! Apologies @swathipil ! I guess revert? I'll manually release this sometime today.

@swathipil
Copy link
Member Author

Sounds good - will remove it from artifacts in ci.yml, then merge. Thanks @scbedd!

@scbedd
Copy link
Member

scbedd commented Aug 18, 2023

Sounds good - will remove it from artifacts in ci.yml, then merge. Thanks @scbedd!

I'm sorry for the revs @swathipil 😞 . Honestly didn't anticipate the error there.

@swathipil
Copy link
Member Author

no worries at all! @scbedd I actually felt that the process was going too smoothly, so glad to see things being righted 🙂

@swathipil swathipil merged commit 1cf5e03 into Azure:main Aug 18, 2023
@swathipil swathipil deleted the swathipil/sr/add-avroserializer-for-deprecation branch August 18, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants