Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure-Core type complete #31502

Merged
merged 24 commits into from
Aug 19, 2023
Merged

Azure-Core type complete #31502

merged 24 commits into from
Aug 19, 2023
+455 −213

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Aug 7, 2023 •
edited
Loading

Status of the PR:

  • mypy, next-mypy clean (even warnings and samples)
  • lot of progress on pyright, but still some mistakes that may be adressed later
  • typing score at 99.7%. Missing 0.3% is a mypy issue (not support of Literal for getattr)

@lmazuel
Pipeline complete

Verified

This commit was signed with the committer’s verified signature.
avkos Oleksii Kosynskyi
GPG key ID: B4A8D3CCE22EA65E
Verified
Learn about vigilant mode
4e024cb
@lmazuel lmazuel requested a review from kristapratico August 7, 2023 23:58
lmazuel added 2 commits August 7, 2023 16:59
@lmazuel
Merge remote-tracking branch 'origin/main' into core_finally_complete

Verified

This commit was signed with the committer’s verified signature.
avkos Oleksii Kosynskyi
GPG key ID: B4A8D3CCE22EA65E
Verified
Learn about vigilant mode
57efe1d
@lmazuel
Missing type

Verified

This commit was signed with the committer’s verified signature.
avkos Oleksii Kosynskyi
GPG key ID: B4A8D3CCE22EA65E
Verified
Learn about vigilant mode
6a102c9
@lmazuel lmazuel marked this pull request as ready for review August 8, 2023 00:01
@lmazuel
Mypy fixes part1

Verified

This commit was signed with the committer’s verified signature.
luu-alex Alex
GPG key ID: 657FDC3BCA81ABC8
Verified
Learn about vigilant mode
fb208d9
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core

lmazuel added 7 commits August 8, 2023 09:28
@lmazuel
Mypy fixes part 2

Verified

This commit was signed with the committer’s verified signature.
luu-alex Alex
GPG key ID: 657FDC3BCA81ABC8
Verified
Learn about vigilant mode
e180df8
@lmazuel
mypy fixes part 3

Verified

This commit was signed with the committer’s verified signature.
luu-alex Alex
GPG key ID: 657FDC3BCA81ABC8
Verified
Learn about vigilant mode
b544fe9
@lmazuel
mypy fixes part 4

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5b07aca
@lmazuel
mypy fixes part 5
c62bbc7
@lmazuel
mypy fixes part 6
05cd769
@lmazuel
Pyright fixes
1f1859b
@lmazuel
CI fixes
b418380
@lmazuel lmazuel mentioned this pull request Aug 11, 2023
Merged
@lmazuel lmazuel merged commit 63476fb into main Aug 19, 2023
@lmazuel lmazuel deleted the core_finally_complete branch August 19, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch

@xiangyan99 xiangyan99

@kristapratico kristapratico

@kashifkhan kashifkhan

@johanste johanste

@tjprescott tjprescott

@iscai-msft iscai-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lmazuel @azure-sdk @kashifkhan @annatisch @xiangyan99 @kristapratico