Use latest swagger #27288
Merged
Use latest swagger #27288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kashifkhan
reviewed
Nov 4, 2022
kashifkhan
approved these changes
Nov 4, 2022
yogeshmo
pushed a commit
that referenced
this pull request
Nov 17, 2022
commit f3fe475294c48b5dc6be33f1c034501c7277f1a6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 16 17:41:18 2022 -0500
Fix minor issue getting stress secret labels with quoting and error handling (#27549)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 8034fa3dc42d4ae8755c73d45fcdee33f729754c
Author: MilesHolland <108901744+MilesHolland@users.noreply.github.com>
Date: Wed Nov 16 16:26:06 2022 -0500
remove todo lines (#27511)
commit 77b67e1f1386f21006f10e9a5bb222c4abdcd63b
Author: Xiang Yan <xiangsjtu@gmail.com>
Date: Wed Nov 16 08:46:58 2022 -0800
Add doc for match condition (#27517)
commit 955a19bfda9bd7725320c67f1286fe2e3e6217ed
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 16 10:33:42 2022 -0500
Increment version for keyvault releases (#27541)
* Increment package version after release of azure-keyvault-keys
* Increment package version after release of azure-keyvault-administration
commit 5862337f9533d9d89d1a839f807de789f6462901
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 16 10:33:09 2022 -0500
Increment package version after release of azure-batch (#27403)
commit 289b4d64855d3348e9f956714e7ce7967d9a3d85
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 16 10:32:54 2022 -0500
Increment package version after release of azure-developer-devcenter (#27426)
commit 8ef37298d06caa0d763c9e4ec28027fff49d40b7
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 16 10:32:31 2022 -0500
Increment package version after release of azure-eventgrid (#27376)
commit 36c4fe39d99624621468723aafb9728d83da1ec3
Author: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com>
Date: Thu Nov 17 00:31:03 2022 +0900
Typo "Azure Monitor application insights"→"Azure Monitor Application Insights" (#27460)
https://learn.microsoft.com/en-us/samples/azure/azure-sdk-for-python/microsoft-azure-monitor-opentelemetry-exporter-trace-python-samples/
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/monitor/azure-monitor-opentelemetry-exporter/samples/traces/README.md
commit 24a9101a6db25a242953d7bd910980a076f033e7
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date: Wed Nov 16 00:09:37 2022 -0800
[Key Vault] Add OKP support for service-side sign/verify operations (#27499)
commit 1148da2d5a75efa429bb7aaa002044d3b6180750
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date: Tue Nov 15 23:07:39 2022 -0800
[Key Vault] Add KeyVaultSettingsClient (#27296)
commit bf00ae1cdd8b395f9f01c751bc32717c03cf0012
Author: Ying Chen <chenyin@microsoft.com>
Date: Tue Nov 15 22:52:03 2022 -0800
Enable Spark related tests (#27501)
* update
* update
* update
* update test
Co-authored-by: Ying Chen <2601502859@qq.com>
commit e79f1ad485ab75085ae09d540a825f0bd307d8b0
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Wed Nov 16 14:49:18 2022 +0800
autorest upgrade (#27523)
commit f0523832b25fc41c814a4b4a432761c9b06621e0
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Wed Nov 16 14:45:01 2022 +0800
fix dependency (#27536)
commit dbca76bd267a94c9fe492168c823c553d20a263b
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Wed Nov 16 13:48:46 2022 +0800
[Compute] update dev dependency (#27528)
* update dev dependency
* Packaging update of azure-mgmt-compute
Co-authored-by: Azure SDK Bot <adxpysdk@microsoft.com>
commit ed95ad5fbf0d3de4eed1260a3b057698e8b6a40d
Author: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com>
Date: Tue Nov 15 16:26:39 2022 -0800
[Storage] Adjust test case for `test_rename_from_a_shorter_directory_to_longer_directory` (#27485)
* Adjust testcase
* Adjust
* undo
commit aaf51641e44b97c9ed0a419a66398556dea76bae
Author: Xiang Yan <xiangsjtu@gmail.com>
Date: Tue Nov 15 15:49:17 2022 -0800
add code snippet doc (#27481)
* add code snippet doc
* Update
commit 099878ef52c3d94586e57e23472575091f5f3f9e
Author: The All-Knowing Yue <96720628+Xingyu-Yue@users.noreply.github.com>
Date: Wed Nov 16 05:39:41 2022 +0800
[xingyuyue/multi_ad_sample] add multivariate anomaly detetor sample f… (#26783)
* [xingyuyue/multi_ad_sample] add multivariate anomaly detetor sample for v1.1
* [xingyuyue/multi_ad_sample] fix anomaly detetor sample for v1.1-preview
* [xingyuyue/multi_ad_sample] fix comments
* Fix aio client
* Fix APIView
* Update anomalydetector sdk
* [xingyuyue/multi_ad_sample] update SDK code
* [xingyuyue/multi_ad_sample] remove azure-ai-anomalydetector-new
* Update change log
* Update changelog
* Update changelog
* Update changelog
* Add anomalydetector to cspell
* Override dependencies for anomalydetector to resolve ci errors
* Update ci yaml for anomalydetector
* Update anomalydetector python sdk
* [xingyuyue/multi_ad_sample] update sdk code
* [xingyuyue/multi_ad_sample] fix sample get error code and message
* Update dependencies for anomalydetector
* Update dependencies for anomalydetector
* Update dependencies for anomalydetector
* Fix typo
* Fix type-extensions troubles
* [xingyuyue/multi_ad_sample] fix ci, readme and shared requirements
* Update sdk
* [xingyuyue/multi_ad_sample] update sdk sample
* Update change log
* [xingyuyue/multi_ad_sample] update sdk code and sample
* [xingyuyue/multi_ad_sample] update sdk async api
* Add Python 3.11 classifier
* update changelog.md to add release date
* [xingyuyue/multi_ad_sample] remove api version in client and update readme
* Update README.md
* Update README.md
* Update README.md
* Update README.md
* Update README.md
* Update README.md
Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: Chunlei Wang <chuwan@microsoft.com>
Co-authored-by: Laurent Mazuel <lmazuel@microsoft.com>
Co-authored-by: jr-MS <81400625+jr-MS@users.noreply.github.com>
commit 3b1c811785fe353aa85e9340e73a9ef6f3e3d8a8
Author: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Date: Tue Nov 15 13:22:36 2022 -0800
Common-sense `tox` environment skipping (#27487)
* move exclusion list to a file within sdk-tools that we can import from random places in the CI. clean up tox_harness as the serial invocation is unused, untested, and worthless.
* type and doccomment all touched functions
* replacing in_ci in favor of ci_tools common version that also honors github actions
* enable filtering based on the opt out lists from the unified exclusion set
* rename tox environment from lint -> pylint. update single reference to said environment. update documentation to reflect new location of exclusion list
* re-add azure-ai-textanalytics and azure-ai-metricsadvisor to opt_out lists
* adding further cspell exclusions
commit 42b3884dc875eaa6f1171c67dbad98523ceaed01
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 15 15:40:18 2022 -0500
Sync eng/common directory with azure-sdk-tools for PR 4701 (#27508)
* Make the env variable upper case
* Adding debug messages.
* Log out the link
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
commit 711d92986d8278c7e24048d98d3bcf5951eb5764
Author: Praven Kuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Tue Nov 15 11:53:52 2022 -0500
update python API parser to 0.3.5 (#27483)
commit 23016825ca59c8e83a26f0988e4de39f86064984
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Tue Nov 15 19:21:00 2022 +0800
[ML][Pipelines] Fix flaky tests in live mode (#27498)
* test: not use pytest.tmp_path to avoid flaky test during ci
* test: wait for more seconds to avoid flaky test
commit 5fd4e9d7cbef10b9ac4691281817763afe1a05d7
Author: Dongwon Shin <ponopono0322@gmail.com>
Date: Tue Nov 15 15:18:40 2022 +0900
[Key Vault] Drop six package in KV (#27377)
commit 415d8b6996344f76bd5a7bd15eed4f42710a98f5
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Tue Nov 15 14:14:03 2022 +0800
[ML][Pipelines] Fix breaking tests in live mode (#27468)
* test: fix reuse test by disabling mock code hash and make these tests only run in live mode
* test: sleep 5s for breaking test in live mode
* test: only enable registry test in master region
* Revert "test: only enable registry test in master region"
This reverts commit a447e4803a777f40f560912a5cef3f04646da4c6.
* test: skip registry test for now
* test: enable `test_mpi_component` in playback mode
* test: add mark "disable_mock_code_hash" for pipeline reuse test
commit 16aff1171a3852aa7093d9c1bb0e4e97ba16f49f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 15 00:19:53 2022 -0500
[AutoRelease] t2-resourcehealth-2022-11-15-38953(can only be merged by SDK owner) (#27491)
* code and test
* Update CHANGELOG.md
* Update _version.py
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
commit bc76e7eb2de5359b5b0b0732cfc08f14bd0d59ba
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 14 22:11:21 2022 -0500
[AutoRelease] t2-appcomplianceautomation-2022-10-26-94903(Do not merge) (#27054)
* code and test
* Update setup.py
* Update shared_requirements.txt
* Update CHANGELOG.md
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 7159b07a14d110a6d1792f4e8504207577780495
Author: Krista Pratico <krpratic@microsoft.com>
Date: Mon Nov 14 16:11:40 2022 -0800
[TA] only run tests where features supported (#27479)
* skip more tests for features only supported in public cloud
* more skips
commit 1af2c6a82adc55895def23e73460f44c11398db2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 14 18:56:23 2022 -0500
Sync eng/common directory with azure-sdk-tools for PR 4632 (#27478)
* Service readme index table stays the same even the table content needs to update
* adjust the edge cases tests
* change the helper function to helper folder
* add missing files
* Fixed the service name
Co-authored-by: sima-zhu <sizhu@microsoft.com>
commit 77877a9760b1c90b66a5a06004883ea0ebcd22f9
Author: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com>
Date: Mon Nov 14 15:43:02 2022 -0800
[Storage] Fix more async test bugs (#27482)
commit d342ab6c6c3076a86266bff2376e857f9f686d82
Author: Libba Lawrence <llawrence@microsoft.com>
Date: Mon Nov 14 13:39:07 2022 -0800
[EG] fix pipeline tests (#27477)
* try this
* had to update apiversion and add in partner resources
* not the samples
commit f0bad9014271ab69b84b05d513a5c211e113278d
Author: Krista Pratico <krpratic@microsoft.com>
Date: Mon Nov 14 11:49:39 2022 -0800
[TA] skip tests for features not supported in other clouds (#27475)
* skip tests not supported in other clouds
* ta is not ready to run verifytypes
commit 2d592a5fb48e5e521ac5bbc74a7786dd6540ae36
Author: Krista Pratico <krpratic@microsoft.com>
Date: Mon Nov 14 11:26:07 2022 -0800
update samples check for mypy to check untyped defs, make sure aka.ms link gets logged no matter what (#27474)
commit fabacd78a3b32c5943ce2701a16e720aa20e4a30
Author: Yalin Li <yall@microsoft.com>
Date: Mon Nov 14 10:47:26 2022 -0800
[Tables] Broaden tests to UsGov and China cloud (#27117)
commit 3482c85d8500e465f16e1b84133068a07a0a03f5
Author: Gabriel Machado <gabriel.ms1@hotmail.com>
Date: Mon Nov 14 18:00:28 2022 +0100
Update README.rst file (#27031)
* Update supported Python version in readme
Match the current supported version and also links to the version support policy
* Update badges
remove older travis badge
update main branch on Azure DevOps build status badge
commit 6d6416dac7e3edcc82bb64e376cd12ad0eb7019e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 14 03:08:45 2022 -0500
[AutoRelease] t2-apimanagement-2022-11-11-20916(can only be merged by SDK owner) (#27450)
* code and test
* Update CHANGELOG.md
* Update _version.py
* Update http_connectivity_check.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 3298e6edcaf86531e7c77ff25f98103944664fa5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 14 03:06:43 2022 -0500
[AutoRelease] t2-notificationhubs-2022-11-11-97598(can only be merged by SDK owner) (#27449)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 2fa9072a64b82ee28a808f7ec9c894b1b02f5a63
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 14 03:05:16 2022 -0500
[AutoRelease] t2-streamanalytics-2022-11-11-35956(can only be merged by SDK owner) (#27451)
* code and test
* update dev_requirement
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
commit 944e848f9e5590375fb3ba92465c9b19ceb4a671
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 14 02:54:31 2022 -0500
[AutoRelease] t2-maintenance-2022-11-11-43402(can only be merged by SDK owner) (#27447)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit c8ebd819225ae5b858d7abcc8cc1b46064cd9e02
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Mon Nov 14 14:39:18 2022 +0800
[ML][Pipelines] Fix validation bug for init/finalize (#27466)
* fix: validate init/finalize when _data is str
* test: add test for bug fix logic
* test: move spark test back to dsl_pipeline class
commit e4269896cc70e8b0eb08f2f4d238e92faffce3cb
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 14 00:45:09 2022 -0500
[AutoRelease] t2-rdbms-2022-11-14-90653(can only be merged by SDK owner) (#27465)
* code and test
* Update CHANGELOG.md
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
commit 3b9785012db5dee4a8fae5bd5682ef438e478b9d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Sun Nov 13 22:59:09 2022 -0500
code and test (#27463)
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
commit 17d82992577bc29410ab9f39d740edb4756f7757
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Mon Nov 14 11:09:16 2022 +0800
try to hide init/finalize in spec (#27446)
commit f76bf82f60ab6143b51f5a7c2724e6eeb4384225
Author: Xingzhi Zhang <37076709+elliotzh@users.noreply.github.com>
Date: Mon Nov 14 10:54:25 2022 +0800
[ML][Pipelines] fix: add environment_variable to CommandComponent schema (#27323)
* fix: add environment_variable to command/distributed
* refactor: make internal command/parallel inheriting parameterized
* feat: enable anonymous reuse with additional_includes
* Revert "feat: enable anonymous reuse with additional_includes"
This reverts commit e288ff152e8673bdfa97e4819b7ba2d7ed8b43c8.
* fix: avoid unnecessary overwrite
* refactor: use DumpableEnumField when no casting
* fix: use tempfile to make test more stable
commit ca26a259193d985b65e9e181a554e1529ccf5751
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Mon Nov 14 10:15:39 2022 +0800
[ML][Pipelines] Enable skip tests during GitHub migration (#27301)
* test: try to enable some gpu-cluster related tests
* update recordings
* fix: update regex for mis-sanitize operation
* test: update recordings due to request behavior change
* test: enable reuse test (for service) in live mode
* test: skip download tests under playback mode
* test: use .gitattributes for test
* test: fix breaking test due to random asset name
commit b50b038e089e87a94d225ee1486fbee4668b7ec9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Nov 11 19:33:52 2022 -0500
updating target version to one with brotli encoding supported (#27457)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
commit d8066419a2a213bbef9e166b91584f605c1d7a4b
Author: TonyJ1 <41344586+TonyJ1@users.noreply.github.com>
Date: Fri Nov 11 15:34:46 2022 -0800
[ML] Retain the cases for the names of system job services (Tracking and Studio) and re-record test_pipeline_job e2e test. (#27443)
* [ML] Retain the cases for the names of system job services (Tracking and Studio)
commit 902e0eb42fb69ccb5daf87a9ceeaa5ec62f1e906
Author: Krista Pratico <krpratic@microsoft.com>
Date: Fri Nov 11 14:53:59 2022 -0800
Type checking updates for CI (#26704)
* update type checking config for repo
* remove unneeded config for mypy
* add pyright as a step
* try running verifytypes
* fix package name
* update version of pyright with bug fix for verifytypes
* don't fail on verifytypes
* update config for both mypy/pyright
* remove
* change ignore list name to match pylint
* add types-redis for identity samples
* fix verifytypes to do score comparison
* add ignore list logic
* add links + fix where we're missing newlinse
* update description
* add packages to opt-out lists
* few fixes
* update docs and remove outdated docs
* fixes to docs
* fix cspell
* use get_ordered_versions for pypiclient
* account for keyerror
* move pylint+others to environment_exclusion_list, fix proxy URL ports
commit f055ac30fb1dcf28314ad088912724a19217e6bc
Author: Krista Pratico <krpratic@microsoft.com>
Date: Fri Nov 11 13:02:28 2022 -0800
[DT] update python version for INT tests (#27304)
* Update tests.yml
* update to specify python version to run for int cloud
commit 4437365b03c29697315fc81952cfd6955f207039
Author: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com>
Date: Fri Nov 11 11:36:41 2022 -0800
[Storage] Fix live test `test_create_service_with_token` (#27408)
commit 13059384d96fa5f05e919cb753b09b15dd7bae72
Author: Leighton Chen <lechen@microsoft.com>
Date: Fri Nov 11 10:40:46 2022 -0800
Implement standard metrics - requests/duration, dependencies/duration (#26753)
commit 1ead01674aa5a3dd2689184b6ef29a8da906e571
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Fri Nov 11 18:40:05 2022 +0800
ci: skip removing test resources for pipelines live test (#27452)
commit 80ea51147c35dfbae2bb89fccaef5a690683161e
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Fri Nov 11 15:53:21 2022 +0800
[ML][Pipelines] Fix bugs & refactor component code asset (#27338)
* refactor: use ignore file for ignoring `__pycache__`
* fix: ignore *.additional_includes
* test: add some test cases
* refactor: just add ignores in pathspec
* fix: super's call bug
* fix: component code bug and change internal code related logic
* refactor: add ignore additional includes to separate class
* remove useless comment
* fix: additional include bugs
* test: add tests for additional includes' behaviour
* test: update hash temp
* fix: pylint errors
* test: remove snapshot id assertion
* test: sync tests for component reuse
* fix: add missing "." for suffix
* fix: breaking test
* Revert "fix: breaking test"
This reverts commit ffa66b5d10e31e5a112a239592353d574f54143e.
* Revert "test: sync tests for component reuse"
This reverts commit 9f4bfacaf0ae89462d73816dd74963ff8c7ab397.
* fix: breaking test by only assert attribute and type
* fix: breaking tests by adding default None value
* refactor: apply the ignore file during copy process
* test: add one for internal component snapshot construction
* refactor: resolve comments
* tests: convert YAMLs to standard schema
* tests: update tests
* tests: add test case for component reuse
* tests: update test to test better
* fix: pylint error
* tests: skip additional includes related component reuse case
* refactor: resolve comments that let IgnoreFile inheritance more clean
* fix: avoid validate additional includes for non-local code
* tests: enable tests
* fix: missing value for parameter
* remove redundant param extra_ignores
* add comment on ValueError
* tests: update test cases
* tests:skip test case for zip additional includes
* fix: special handle for git code
* test: refine tes by manually listing, avoid breaking due to temp folder like __pycache__
* test: check dir exist first to avoid transient breaking during CI
* test: check dir exist first to avoid transient breaking during CI
commit 5daafa381c5170f153c73421f44d38290473a3f5
Author: Brynn Yin <24237253+brynn-code@users.noreply.github.com>
Date: Fri Nov 11 12:49:15 2022 +0800
[ML][Pipelines] Support command schedule (#27339)
* Support local command job schedule
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* Add recording
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* Remove unused
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* change node to job
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* Update recording
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* Refine schema to reuse Job schema
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* Fix compute
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* Fix schema
Signed-off-by: Brynn Yin <biyi@microsoft.com>
* Update recording, add private flag check
Signed-off-by: Brynn Yin <biyi@microsoft.com>
Signed-off-by: Brynn Yin <biyi@microsoft.com>
commit 7f456b36c253e3ae49975a0940bfff15cf22ecc5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 21:08:24 2022 -0500
[AutoRelease] t2-desktopvirtualization-2022-11-09-11492(can only be merged by SDK owner) (#27393)
* code and test
* Update CHANGELOG.md
* Update _version.py
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit eb8c760785ce5851433944939fdb23fbcca5cddf
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 21:07:31 2022 -0500
[AutoRelease] t2-quota-2022-11-09-21486(can only be merged by SDK owner) (#27391)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit ee3c6ceb8e6340727705f7da23d13092e6a3c309
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 21:05:57 2022 -0500
[AutoRelease] t2-hybridkubernetes-2022-11-09-35476(can only be merged by SDK owner) (#27387)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit e4137ac9709e96432ce86d3b13c0b73dc70de622
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 21:05:09 2022 -0500
[AutoRelease] t2-baremetalinfrastructure-2022-11-09-21802(can only be merged by SDK owner) (#27388)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 7a0dd11852900a0fbc84ac5a9a7c0658a6a8bcf3
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 21:03:33 2022 -0500
code and test (#27421)
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
commit 1e57a7ec3add18481e1c2d71ea19ed87f3153315
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 21:01:02 2022 -0500
[AutoRelease] t2-storagepool-2022-11-09-65027(can only be merged by SDK owner) (#27389)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit a90c588e92c62f3119f7c2ad22903b7fc2895c54
Author: Krista Pratico <krpratic@microsoft.com>
Date: Thu Nov 10 16:26:18 2022 -0800
unksip tests where service bugs have been fixed (#27442)
commit 06e73e2aabb1399db230a91039326e6e03a81230
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 19:03:35 2022 -0500
Increment package version after release of azure-monitor-opentelemetry-exporter (#27440)
commit 36ee82380538b0e03d011a12dde2bbd4bfd29dd9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 18:45:22 2022 -0500
Increment package version after release of azure-ai-language-conversations (#27435)
commit 3cb4c653b6c14108a46caa416d20e7e4185ff9d2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 17:28:17 2022 -0500
Warn user when helm fails due to large files not being ignored (#27434)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 5cb4fc700644605a57fb310e39cb658653043fa2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 16:49:12 2022 -0500
Handle possible strict mode bugs (#27433)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 80e5718186f645ee0406603bf05b82795f4c5cd9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 10 16:35:19 2022 -0500
Add optional TestResourcesDirectory override parameter (#27432)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit ea9fb9963f369f0636fb8fcb79e4b7f3d7395364
Author: nthande <90645783+nthandeMS@users.noreply.github.com>
Date: Thu Nov 10 11:03:41 2022 -0800
[ML] Updated parameter name to be idle_time_before_shutdown_minutes (#26898)
* Updated parameter name to be idle_time_before_shutdown_minutes
commit fa35cd496da4a7aea3a966ec0fbb28a3f3b969aa
Author: Leighton Chen <lechen@microsoft.com>
Date: Thu Nov 10 10:54:04 2022 -0800
Update CHANGELOG.md (#27430)
commit 51de6b0157fd54b890daf9b0565c805488814ea2
Author: Leighton Chen <lechen@microsoft.com>
Date: Thu Nov 10 09:51:10 2022 -0800
fix local storage -> offline storage rename (#27414)
commit db7ac352b0003229877fa0e7a5f4f43aafbbcf7a
Author: Korin <0mza987@gmail.com>
Date: Thu Nov 10 17:55:16 2022 +0800
[ML]Remove empty attributes when node -> RestObj and component -> component dict (#27335)
* remove empty value in node._to_rest_obj() and fix dsl unit tests
* fix pipeline_job tests
* fix schedule tests
* fix component tests
* fix internal tests
* update base_node._to_rest_obj()
* update
* fix test_command_function
* exclude [] from empty target list
* fix e2e tests
* fix typo
* update recordings
* update
* update registry recording
* update recordings
* update recordings
* skip broken tests
* fix comment
* fix pylint
commit 4d8db253e6b3deb96c2fc260d639227eead58695
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Thu Nov 10 17:48:38 2022 +0800
tests: change vmsize for gpu-cluster when in eastus2euap (#27416)
commit 2a809a3e6d848a0b33e046316bcc887215816f89
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Thu Nov 10 16:03:14 2022 +0800
fix (#27417)
commit 5866638c2476516bd712a6c72d9301ba4e8acbe1
Author: hazemelh <45972073+hazemelh@users.noreply.github.com>
Date: Thu Nov 10 03:17:11 2022 +0200
Create sample_assign_deployment_resources.py in Language Authoring (#27237)
* Create sample_assign_deployment_resources.py
* Adding more description
* Add async version
* Add description
* some edits + skip samples running in ci for now
* fix link
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
commit 43ffeb50b12f1e96d41f8535a81e8ff8759067d1
Author: nthande <90645783+nthandeMS@users.noreply.github.com>
Date: Wed Nov 9 16:18:53 2022 -0800
[ML] Added datastore and job to allowed input types for Jobs (#26814)
* Added datastore and job to allowed input types
commit 16978d8f4361e3d4295b823146c9319f5a370c6b
Author: Mike <jabbera@users.noreply.github.com>
Date: Wed Nov 9 19:07:26 2022 -0500
Fix missing attribute (#27405)
commit 57a6d95d6fb401457882c1867081180217faf406
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 9 19:05:16 2022 -0500
Increment package version after release of azure-monitor-opentelemetry-exporter (#27399)
commit 019b5ab13a622375f6e350d29b4dc385d13aa132
Author: Rajarshi Sarkar <73562869+sarkar-rajarshi@users.noreply.github.com>
Date: Wed Nov 9 15:13:19 2022 -0800
[ACS JobRouter] Test proxy migration (#27394)
* Router test proxy migration
- update all tests using test proxy
- recordings updated
* move initialize_test to conftest.py
* move conftest.py to correctly pass in test method name while initializing test
commit 9b3f130202cb8ffd371c0cb190cc0b0fc2ef4b19
Author: Ben Broderick Phillips <bebroder@microsoft.com>
Date: Wed Nov 9 16:22:11 2022 -0500
Updating check enforcer permissions to enable writing comments (#27401)
commit 7d95381cbe659e0e055eeb5e0c76e00a014a3f3f
Author: nancy-mejia <106106141+nancy-mejia@users.noreply.github.com>
Date: Wed Nov 9 12:23:36 2022 -0800
[ML] Extend error messages for environment, model, online/batch endpoints and deployments (#27378)
commit 9c4492a5f9aaf24c771cf380e2fe11acc0979601
Author: MaurisLucis <nmecklenburg@berkeley.edu>
Date: Wed Nov 9 11:35:37 2022 -0800
Fix NoneType Early Termination Policy bug for NLP (#27374)
* adapt same fix as vision for nonetype early termination policy bug
* fix typos
Co-authored-by: Nick Mecklenburg <nmecklenburg@microsoft.com>
commit d8af89366f398fc84fa0e80fe5750fe1d91a78ee
Author: Ronnie Geraghty <rgeraghty@microsoft.com>
Date: Wed Nov 9 09:09:35 2022 -0800
[BOT RULES] Cognitive - Personalizer (#27341)
Bot Rules to match code owners changes in #27294
commit e72dae39e14923ab5e073500bddb123733f78c9d
Author: zhenbiao wei <424401670@qq.com>
Date: Wed Nov 9 16:39:11 2022 +0800
Update README.md (#27392)
commit 442fb0e6e18a8ed4ce39f6021737da046b1f84c6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 9 01:54:24 2022 -0500
[AutoRelease] t2-servicefabric-2022-11-08-83337(can only be merged by SDK owner) (#27363)
* code and test
* Update CHANGELOG.md
* Update _version.py
* Update sdk_packaging.toml
* Update README.md
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
commit 8e0caa5088b5b29eb487eb5d0a110d076d66740b
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 9 01:09:26 2022 -0500
[AutoRelease] t2-containerservice-2022-11-02-79096(Do not merge) (#27243)
* code and test
* Update CHANGELOG.md
* Update CHANGELOG.md
* Update _version.py
* Update _version.py
* Update _version.py
* Update _version.py
* Update _version.py
* update all version
* Update CHANGELOG.md
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
commit 7c16f091c8a7d6414542a6a1cc077b9949b3097b
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 9 00:05:12 2022 -0500
code and test (#27358)
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
commit c78163074ac3b3d879e21565a17e07cec06f6217
Author: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com>
Date: Tue Nov 8 18:06:00 2022 -0800
[Storage] Refactor tests in `test_avro_async.py` (#27370)
* Remove event loop to attempt to fix CI
* PR feedback
commit 0d080eef1ad4beccbbf4b81c62ec6866edea1dd2
Author: Man <43016276+Man-MSFT@users.noreply.github.com>
Date: Tue Nov 8 17:47:05 2022 -0800
[ML] Return object ID if object already has ID (#27350)
* Fix ARM id retrieval for registry environments
* Update changelog
* Update test_operation_orchestrator.py
Fix enum casing
* [ML] Return object ID if object already has ID
* Update changelog
* Fix typo
* Fix typo
* Update test_operation_orchestrator.py
commit 6ccde6026dad9190fa09b8f269c0219749a7c23c
Author: Xingzhi Zhang <37076709+elliotzh@users.noreply.github.com>
Date: Wed Nov 9 09:29:08 2022 +0800
git: add pre-commit configuration to .gitignore (#27162)
* pre-commit: simple pre-commit to run pylint check for azure-ai-ml
* git: add pre-commit configuration to .gitignore
commit 65b1e1aba3515dec1189d3997afa489e2450dd31
Author: Leighton Chen <lechen@microsoft.com>
Date: Tue Nov 8 15:07:32 2022 -0800
Update CHANGELOG.md (#27371)
commit 238eac47133db43c8d00030ec8cac4923439cee9
Author: Libba Lawrence <llawrence@microsoft.com>
Date: Tue Nov 8 14:46:43 2022 -0800
[EG] Drop 3.6 update docs (#27373)
* 3.6 was removed
* remove 3.6
commit 731287612d8a8f936acb4ab34e53499da10a5db5
Author: Krista Pratico <krpratic@microsoft.com>
Date: Tue Nov 8 14:41:44 2022 -0800
[CLU] update docs for beta release + add example of how to export project (#27346)
* update docs for beta release + add example of how to export project
* make sure we test run sample
* fix bad links to samples
* update changelog date
commit 35ae992b40957ffffc66edb2d93d5b9b8c7ab3a0
Author: Sean Brennan <sebrenna@microsoft.com>
Date: Tue Nov 8 14:18:54 2022 -0800
[DevCenter] Preparing for azure-developer-devcenter 1.0.0b1 release (#27308)
* preparing for release
* Packaging update of azure-developer-devcenter
* Revert "Packaging update of azure-developer-devcenter"
This reverts commit 132febf4436ca0be2c7dfd4b3b8637d8965b5d58.
* Packaging update of azure-developer-devcenter
* Revert "Packaging update of azure-developer-devcenter"
This reverts commit 1408290ccbf9c395ac7dcbd08ded37cee87577a3.
* excluding auto-updates from bot
Co-authored-by: Azure SDK Bot <adxpysdk@microsoft.com>
commit 083f10566d828046c826f56414dbec1ef4e2838a
Author: Hanchi Wang <luigiking307@gmail.com>
Date: Tue Nov 8 13:02:21 2022 -0800
Update registry detete method return type (#27366)
commit 34ba025fbed9279c7f8aa61834d456465fe0e338
Author: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Date: Tue Nov 8 13:00:12 2022 -0800
patch the assumption in is_required_version_on_pypi (#27369)
commit d4d400de594d1f51d26f6dd23ec3a1894623b14f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 15:55:15 2022 -0500
Increment package version after release of azure-core (#27283)
commit c790c4111fb838d2584098d82b1e4831712b569c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 14:26:46 2022 -0500
Increment package version after release of azure-search-documents (#27367)
commit d5a3344d5ab598a43de319bca7e5435f95b636ac
Author: Jeremy Voss <jerevoss@gmail.com>
Date: Tue Nov 8 11:07:34 2022 -0800
Added Sampler Factory (#27236)
commit 77cc63b1ce1801e8720fec7d28b9275c5fc782cb
Author: jessicawrr <jessicawrr@gmail.com>
Date: Tue Nov 8 09:56:11 2022 -0800
Create sample code for conversational sentiment (#27359)
* Create sample code for conversational sentiment
* small edits, add async sample, add samples to readme
Co-authored-by: Ranran Wang <rawan@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
commit fb0e0a2288609718a79f7c0e3049882c23a4d5ec
Author: Hanchi Wang <luigiking307@gmail.com>
Date: Tue Nov 8 09:48:19 2022 -0800
[ml] Switched compute operations to go through 2022-10-01-preview API version (#26964)
* Update autorest code for 2022-10-01-preview API version
commit f151ebd058635b46a83441ff69146aa04032bee5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 12:46:45 2022 -0500
Set default LimitRange for stress container resource requests (#27313)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 8dfd36fec941ca85e9bb34118cd7c77c8b8069ff
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 12:35:23 2022 -0500
Increment package version after release of azure-identity (#27365)
commit 339aa5b1029198ecbe6da66ca48c30bddbf57018
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 04:00:56 2022 -0500
[AutoRelease] t2-relay-2022-11-08-46875(can only be merged by SDK owner) (#27362)
* code and test
* Update CHANGELOG.md
* Update _version.py
* fix test break
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
commit 9cfc15a280ce79420c14de528a320f3fe3d96b57
Author: Zhengfei Wang <38847871+zhengfeiwang@users.noreply.github.com>
Date: Tue Nov 8 16:53:06 2022 +0800
[ML][Pipelines] Support expression in if-else (#27275)
* resolve expression to command component in condition
* move resolve to dsl.condition
* fix: command for component output
* fix: expression node issue
* fix: expression node parameter name issue
* fix: pylint error for unused import
* fix: use v2 contract in expression command
* fix: command syntax error
* refine: add logic convert node to output
* test: add test for control node consuming expression/component
commit 994ed7bfd06a893ca1687311583d3daa1f816af6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 02:37:49 2022 -0500
[AutoRelease] t2-logz-2022-11-08-54068(can only be merged by SDK owner) (#27360)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit d18783b4881e3fbc815e16ad12cc612d825ce695
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 02:36:42 2022 -0500
[AutoRelease] t2-costmanagement-2022-11-07-60744(can only be merged by SDK owner) (#27332)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit de545f4af6f31119334c00715050deabf5043dda
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 02:35:26 2022 -0500
[AutoRelease] t2-purview-2022-11-07-29378(can only be merged by SDK owner) (#27330)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 7fd87e7ede93853b92abb3fc758d7df0d57d17d4
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 02:33:57 2022 -0500
code and test (#27329)
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
commit 4c0985335369ddbeff73597d6097406b07bc68b7
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 8 00:02:11 2022 -0500
code and test (#27356)
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
commit 461dff5f295fa026975198ef2a825f6cb9e1008f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 7 23:11:18 2022 -0500
Increment package version after release of azure-ai-personalizer (#27352)
commit 9ffa8b82d8bda0c6374a375df9a4b97742d7fcb6
Author: Krista Pratico <krpratic@microsoft.com>
Date: Mon Nov 7 20:10:32 2022 -0800
add typing docs (#26084)
* add docs/cheatsheet
* anna's feedback
* more feedback
* feedback applied to cheat sheet and longer doc
* swathi's review feedback
commit 0fbd42a783e229c8d8cf250b56f3857b5c34f469
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Tue Nov 8 11:55:13 2022 +0800
Release helper optimize (#27355)
* optimize
* optimize
* optimize
commit 74fe7f27e380ec87fa3fa8ab863e2bb7a1f18181
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Tue Nov 8 10:37:17 2022 +0800
Update setup.py (#27272)
commit 538ee7e3a7daa83b6fb1caeffa88afb28fe9d136
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Tue Nov 8 09:48:33 2022 +0800
[pipeline] remove outdated samples in pipeline (#27324)
* remove outdated samples
* remove outdated samples
commit 5753c1966a7aa1e869f675c8a9b04402e8625f3e
Author: Paul Van Eck <paulvaneck@microsoft.com>
Date: Mon Nov 7 17:28:17 2022 -0800
[Monitor] Fix live tests (#27353)
Live tests fail due to a missing required positional argument error.
This fixes that.
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
commit b2d5a9a2d0d70d400da562ecef5e5dafa14cc729
Author: Paul Van Eck <paulvaneck@microsoft.com>
Date: Mon Nov 7 16:38:59 2022 -0800
[Monitor][Ingestion] Remove msrest dependency (#27315)
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
commit de985763a3139e2c4354203c179ff863cd2c378b
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 7 18:38:39 2022 -0500
Add public cloud cosmos endpoint suffix (#27307)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 4d4feae8c2a651be4159e0f7e76ab1070d9bd3bb
Author: Yalin Li <yall@microsoft.com>
Date: Mon Nov 7 13:09:27 2022 -0800
Update tests.yml (#27311)
commit 6c9c01938a137ca03934d3b2eefdcdf9de296147
Author: Libba Lawrence <llawrence@microsoft.com>
Date: Mon Nov 7 12:43:31 2022 -0800
[EventGrid] updating healthcare enums (#27312)
* updating healthcare enums
* changelog
* spellchecker
* remove changelog sections
* whitespace
commit 850b559105de0dfa23964a6ebca8b956d5e63dbd
Author: Hanchi Wang <luigiking307@gmail.com>
Date: Mon Nov 7 12:39:08 2022 -0800
[ml] UnExpectedNonPipelineParameterTypeError to UserErrorException (#27344)
* back to UserErrorException
* revert recordings
commit 14ce50e905ea8bb9c9ec28d0d894b3402bfd780d
Author: MilesHolland <108901744+MilesHolland@users.noreply.github.com>
Date: Mon Nov 7 15:34:26 2022 -0500
Add registry replication count value (#26932)
* schema changes an initial support class changes
* context switch changes
* swagger changes
* update tests and add tests for replicated ids
* nits
* fix lint issues
* linting pass
* pylint second pass
* fix merge
* get e2e test passing again after merge
* more testing
* remove pdb
* linting
* comment nits
* rerun test recordings after main merge
* remove description
* schema deserialization fix
* fix lint
* add replication count check at conversion
commit 1f6b37670b3ef847f6ace52d6283cab14c35241f
Author: Timo Wilhelm <mail@timowilhelm.com>
Date: Mon Nov 7 19:59:52 2022 +0100
[Azure Monitor] [OTEL Exporter] Fix azure monitor redirect error logging (#27321)
commit 1846d23c1da88647146b2614c2851255abed1491
Author: Krista Pratico <krpratic@microsoft.com>
Date: Mon Nov 7 10:30:58 2022 -0800
fix weekly pipeline (#27340)
commit ff0006512364a6c40837d91c406eb2b3c34c2491
Author: Krista Pratico <krpratic@microsoft.com>
Date: Mon Nov 7 10:16:13 2022 -0800
Update codeowners for personalizer (#27294)
commit 2e34f02fcb7d4a6cc11ec08714b6356824822cc1
Author: Krista Pratico <krpratic@microsoft.com>
Date: Mon Nov 7 09:01:16 2022 -0800
docs sweep for the beta (#27316)
commit 4c8c97a9d8d9867c97107f73c6d23fb04dce1f88
Author: Laurent Mazuel <laurent.mazuel@gmail.com>
Date: Mon Nov 7 08:42:22 2022 -0800
Update CODEOWNERS
commit 1d023ea51e9d4acdf90b2b89dd4b8fa6d3db585a
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 7 00:57:46 2022 -0500
[AutoRelease] t2-vmwarecloudsimple-2022-11-02-62501(Do not merge) (#27248)
* code and test
* Update CHANGELOG.md
* Update _version.py
* Update CHANGELOG.md
* Update CHANGELOG.md
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
commit f4c057261fa91e55e1dbf122a91ab7ee23b7806f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Sun Nov 6 21:14:37 2022 -0500
[AutoRelease] t2-testbase-2022-11-04-74314(Do not merge) (#27299)
* code and test
* update dev_requirement
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
commit a8058fee30342834ec1b721da0d9c2a36d94a83f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Sun Nov 6 21:14:29 2022 -0500
[AutoRelease] t2-guestconfig-2022-11-04-91818(Do not merge) (#27297)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 72e615e6eb5371cef676b80c0c2d5a9020ec8f91
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Sun Nov 6 21:05:24 2022 -0500
[AutoRelease] t2-resourcemover-2022-11-04-82067(Do not merge) (#27300)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit c2fefdf444bb5d822f48d90b893247ac374bc9da
Author: Yuchao Yan <yuchaoyan@microsoft.com>
Date: Mon Nov 7 09:59:45 2022 +0800
Update main.py (#27322)
commit d96c2a3caf8fc640d43d92360f240677cf7efd4f
Author: Man <43016276+Man-MSFT@users.noreply.github.com>
Date: Sun Nov 6 16:39:20 2022 -0800
AzureML: Fix ARM ID for registry environments (#27305)
* Fix ARM id retrieval for registry environments
* Update changelog
* Update test_operation_orchestrator.py
commit 118e99f44b6f1314ba1739c43ce97a7c8e7250c6
Author: nancy-mejia <106106141+nancy-mejia@users.noreply.github.com>
Date: Fri Nov 4 15:27:49 2022 -0700
[ML] Fix add missing "properties" to batch deployment (#27292)
commit a10fb9c02afc9cdab9273d35cb335cd963411975
Author: Yalin Li <yall@microsoft.com>
Date: Fri Nov 4 14:19:05 2022 -0700
Use asyncio.run() (#27289)
commit d43a37b14b28f595912ed57de94ffa580657b410
Author: Yalin Li <yall@microsoft.com>
Date: Fri Nov 4 13:51:45 2022 -0700
[AppConfig] Close async clients (#27287)
commit 5a79ca8ab3ab460e5a5a9a42841b2e105becf447
Author: Xiang Yan <xiangsjtu@gmail.com>
Date: Fri Nov 4 12:50:16 2022 -0700
Use latest swagger (#27288)
* Use swagger #904899a23a417768ce1ec1d5f89f33817f8ef8ad
* update
* updates
* update changelog
commit d08c4f43f457befd2da258e3acaa8f08b4295f1c
Author: wiboris <54044985+wiboris@users.noreply.github.com>
Date: Fri Nov 4 11:55:06 2022 -0700
[Batch] Data plane SDK v13.0.0 (#27172)
* update dataplane to 2022-10-01 api
* updating changelog
* revert testing code
* fix tests
* fix test
* update msrest version
* Revert "update msrest version"
This reverts commit 3e7b9073340a53d29c22cd11e9f7451de517fb70.
* trying to fix dependency conflix
* updating release date
* updating changelog
commit 643617742baba866514ae98674c042d5eca10c71
Author: nancy-mejia <106106141+nancy-mejia@users.noreply.github.com>
Date: Thu Nov 3 22:24:04 2022 -0700
Re enable batch endpoints/deployments e2etests (#27177)
* Re enable batch/online endpoints e2etests
commit 389861cd767bcc37c94fe6f8b00d923ecf18d7b7
Author: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com>
Date: Thu Nov 3 20:52:14 2022 -0700
Fix `test_abort_copy_blob` (#27293)
commit ab8b4c03dc34099b688028f79f89fbc3efef410f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 3 22:06:45 2022 -0400
[AutoRelease] t2-logic-2022-11-02-97736(Do not merge) (#27251)
* code and test
* Update CHANGELOG.md
* Update _version.py
* Update CHANGELOG.md
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 4fbe028650cd995eebe92f51f1d996b7c47b36a0
Author: Sharath Malladi <msharath@live.com>
Date: Thu Nov 3 18:52:33 2022 -0700
Adding Personalizer SDK for Python. (#26719)
* Adding Personalizer SDK for Python.
* record tests
* remove default_language on async client
* remove locale from link
* update dependencies and shared reqs overrides
* get mypy clean
* Enable multislot before making multi slot rank and reward calls.
* update recordings for personalizer
* Separate client into PersonalizerClient and PersonalizerAdministrationClient.
Remove helper methods from samples and link to the simulation tutorial.
* Fix errors from tox commands.
* Reacting to feedback.
* Fixed pylint errors.
* Removed operation groups and added tests for feature importance.
* Rename get_model to export_model.
* Enable create feature importance tests.
* Rename functions in swagger to avoid creating operation groups.
* Adding examples in doc strings and examples in README file.
* Add send_request method.
* Use variables to store random guids for evaluations and feature importances.
* Addressed all feedback and generated the recordings again.
* Changing location to Canary in the tests.yml file instead of test-resources.json.
* Use preset resources for creating evaluations and feaure importance as they depend on cooked logs.
* Updated samples to use environment variables output after creating test resources.
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
commit ae5480cf05c89e47876c5a6625c2c359d212ece8
Author: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com>
Date: Thu Nov 3 18:21:57 2022 -0700
[Storage] Migrate `test_queue_service_stats.py` to test proxy (#27286)
* JSON is invalid
* Wip
* Done
commit 653d77ceb1440ad8bb13a1b0630db23d723e0dd7
Author: Krista Pratico <krpratic@microsoft.com>
Date: Thu Nov 3 18:21:15 2022 -0700
[TA,DT] api_version enum update (#27282)
* api version update for enum change in py311
* pylint
commit 0063fb2399e7d9926d331769eec4c70674e537c6
Author: Paul Van Eck <paulvaneck@microsoft.com>
Date: Thu Nov 3 16:52:38 2022 -0700
[Monitor][Query] Add docs about stats and vis (#27263)
Two sections in the README were added to demonstrate how
users can retreive statistics and visualization data
when performing log queries.
Closes: #23311
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
commit 0642a94a3d331c585a840440271c11e714f2c9a6
Author: Paul Van Eck <paulvaneck@microsoft.com>
Date: Thu Nov 3 16:16:51 2022 -0700
[Monitor] Documentation updates (#27271)
* Add a section about log retrieval to ingestion README
* docs.microsoft.com -> learn.microsoft.com
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
commit 33e744c296023a776dac3e950e54157f16ce23f2
Author: Paul Van Eck <paulvaneck@microsoft.com>
Date: Thu Nov 3 15:40:54 2022 -0700
[CI] Fix typo in file path (#27285)
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
commit 7adf652e79ce143ca7a5cb8ee5db33ff842ecd47
Author: Leighton Chen <lechen@microsoft.com>
Date: Thu Nov 3 15:36:43 2022 -0700
py11 (#27281)
commit afce7bfefab2af278edc9e84b7a453546f3312f0
Author: Xiang Yan <xiangsjtu@gmail.com>
Date: Thu Nov 3 14:08:53 2022 -0700
add snippet update step (#26899)
* add snippet update step
* Get latest main (#26934)
* Change default local storage location (#26891)
* code and test (#26908)
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
* Update swagger_to_sdk_config_dpg.json (#26913)
* feat: enable internal components in pipeline yaml (#26800)
* feat: enable internal components in pipeline yaml
* refactor: add some gate logic
* fix: fix test_pipeline_job_create_with_registries
* fix: fix pylint
* Cadl automation pipeline (#26912)
* cdoe
* fix
* code
* fix
* code
* meta.json
* meta.json
* compatible
* refactor: divide pipeline related tests (#26886)
* fix: sdk.ml.azure-ai-ml.tests.datastore.e2etests.test_datastore
* feat: component with default label
* refactor: divide test_dsl_pipeline.py
* feat: load labelled arm id
* feat: support name@default
use name@label for node component in pipeline yaml
* [TA ] improve per-document error message when all documents fail per action (#26902)
* fix bad Document error message when all actions fail
* update changelog
* update wording
* skip cosmos emulator (#26930)
* try 3.7
* skip cosmos emulator tests until fixed
* revert change
* comment out emulator
* fix ci for core (#26923)
* fix ci for core
* updates
* updates
* updates
* updates
* updates
* adding additional version override support
* update
* update
* update
* update conda test-requirements to include azure-mgmt-storage that was previously coming dependency tools/azure-sdk-tools
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Xingzhi Zhang <37076709+elliotzh@users.noreply.github.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* update
* update
* update
* update
* update
* Update update_snippet.yml
* Update eng/pipelines/templates/steps/analyze.yml
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update update_snippet.yml
* update
* update
* update
* updates
* update
* Updates
* updates
* updates
* update
* Add comments
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Xingzhi Zhang <37076709+elliotzh@users.noreply.github.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
commit 2cb703c87644f5d09b14e4f8b6d933d7760d46da
Author: Xiang Yan <xiangsjtu@gmail.com>
Date: Thu Nov 3 13:26:01 2022 -0700
Add 3.11 support (#27276)
commit 824868d74e48bf7f7876d046815bd907f9fd474f
Author: Neehar Duvvuri <40341266+needuv@users.noreply.github.com>
Date: Thu Nov 3 16:01:46 2022 -0400
Move AutoML Live Tests to EastUs and Change GPU SKU (#27280)
* Move AutoML Tests to EastUs
* Change GPU SKU
* remove new line
* add bck new line
commit 8fa28c1f18657f986b5037258cbbfe16b92ab80c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 3 15:23:52 2022 -0400
target newest version of proxy tool (#27278)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
commit 2b96b8fb0003b5183e1a025ad75b7a00fca4ff03
Author: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Date: Thu Nov 3 11:58:21 2022 -0700
Start Resolving Regression Failures (#27268)
* patch the hole in our requirement parsing
* cleanup unused usings
commit da0a1fc1eca9e327a1bbd6c24f6355865d018621
Author: Krista Pratico <krpratic@microsoft.com>
Date: Thu Nov 3 10:35:46 2022 -0700
[CLU] add LRO return types and tests (#27040)
* regenerate with return types for LROs and update changelog
* more changelog updates + add some tests
* add tests for chapterTitle and narrative summaryAspects
* regenerate on latest, add typing-extensions to setup.py
* fix ci
* add missing transform
* py311 updates
* update readme with conv sentiment example
* fix links where they differ between runtime ops
* add typing-extensions to shared_reqs for clu
* update commit and regenerate
commit 392fba51e35d2260d36a29be193f57c68f0480b9
Author: Joshua Loeffler <102193043+jloeffler7@users.noreply.github.com>
Date: Thu Nov 3 12:14:38 2022 -0400
Remove UpdateSubnetPolicy task from workspace deployment template (#27256)
Co-authored-by: Joshua Loeffler <jloeffler@microsoft.com>
commit 453f2c3692aaffb045317bb3deeb3b93e7bb73f0
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 3 06:24:03 2022 -0400
[AutoRelease] t2-storageimportexport-2022-11-02-17191(Do not merge) (#27249)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit f76edd0f74895704bc579fa4de3fec7f6c4bf4ac
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 3 06:23:16 2022 -0400
[AutoRelease] t2-devspaces-2022-11-02-83087(Do not merge) (#27250)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 1311ed9c37d0b2349cc131104d4282ff9b510c1c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 3 06:22:37 2022 -0400
[AutoRelease] t2-datadog-2022-11-02-41084(Do not merge) (#27247)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit 010f5708fd4a03b2a35bf33d5ef02b2962846ba0
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Nov 3 06:21:59 2022 -0400
[AutoRelease] t2-confluent-2022-11-02-18721(Do not merge) (#27246)
* code and test
* Update CHANGELOG.md
* Update _version.py
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: zhenbiao wei <424401670@qq.com>
commit ed691f3888a5c712a2cea77dd06afb9ad4ef9a8b
Author: Ming <hemingwei2017@gmail.com>
Date: Wed Nov 2 19:48:49 2022 -0700
fix aml workspace schema types mismatch for show operation (#27269)
* Update changelog
* fix workspace.identity.UAI types mismatch for show operation
* revert the change log
* fix pylint issue
Co-authored-by: Diondra Peck <16376603+diondrapeck@users.noreply.github.com>
Co-authored-by: Mingwei He <mingweihe@microsoft.com>
commit 502727be58ebe1a920100ef2b8af259ea3332361
Author: Ankit Singhal <30610298+singankit@users.noreply.github.com>
Date: Wed Nov 2 19:20:42 2022 -0700
Adding azure-ai-ml dependencies to shared requirements (#27033)
* Adding azure-ai-ml dependencies to shared requirements
* Update shared_requirements.txt
* Update shared_requirements.txt
* Update shared_requirements.txt
Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com>
commit cfcfb0fa04b79f4d0edbe130c664292ce98091ae
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date: Wed Nov 2 16:58:57 2022 -0700
[Key Vault] Regenerate with latest `autorest` and API versions (#27170)
commit 65ad7213ad6e71b844daf45551cee71cd6876977
Author: Hanchi Wang <luigiking307@gmail.com>
Date: Wed Nov 2 16:58:27 2022 -0700
[ml] Address feedback on Nov release public interface (#27261)
* Address feedback on Nov release public interface
* pylint
commit 11caf9659a5332f2a833a9cf869dd2b556f31e55
Author: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com>
Date: Wed Nov 2 16:49:02 2022 -0700
[Storage] Migrate `test_queue_encryption.py` to test proxy (#27209)
* Sync done live&recorded
* Clean up imports for sync
* Finished async live&recorded
* Adjust testcase
commit 9e80b7e487f23221c6d125c178df295edc27eb41
Author: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com>
Date: Wed Nov 2 16:48:44 2022 -0700
Done (#27264)
commit 130bf46394125483cba0ec1fcc49718cdac0b9c9
Author: Douglas <74578557+DouglasXiaoMS@users.noreply.github.com>
Date: Wed Nov 2 16:22:02 2022 -0700
Fix spark job status show in az ml job command (#27267)
commit 45e78d7414233f16e0631cb5c811d88e27f94832
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 2 18:09:14 2022 -0400
cspell issues in cpp branch , needs updated node, and cspell and npx need to be installed for cspell to run (#27262)
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
commit d3428bcb9fbadb5f1ac34dfde83739ec4f04862a
Author: TonyJ1 <41344586+TonyJ1@users.noreply.github.com>
Date: Wed Nov 2 13:18:20 2022 -0700
[ML] Mark JobService class and services param to command() as experimental (#27259)
* Update command_func() to accept a strongly typed services dictionary and update the tests/documentation
* update changelog.md
* [ML] Mark JobService and services param to command() as experimental
commit 8003a58101aefb8e0d4e0007f1c2c8d02a700c66
Author: Krista Pratico <krpratic@microsoft.com>
Date: Wed Nov 2 10:59:53 2022 -0700
[TA] py311 and beta updates (#27233)
* py311 and beta updates
* add back azure-common
* add dynamic classification to enum
* add isodate to shared_reqs for ta
commit 69f2868371478308d11bbcf4541df060f64ae10c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 2 13:17:42 2022 -0400
Add package source override to toc script. (#27234)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
commit cf9e648a9c772feafe3aa3986d52e5f8422d12a4
Author: TonyJ1 <41344586+TonyJ1@users.noreply.github.com>
Date: Wed Nov 2 10:16:34 2022 -0700
[ML] Command function now accepts services param of type Dict[str, JobService] instead of dict (#27231)
* Update command_func() to accept a strongly typed services dictionary and update the tests/documentation
* update changelog.md
commit f12f754f5c59cf52587b739ce126f4f2c3b0efa3
Author: Xingzhi Zhang <37076709+elliotzh@users.noreply.github.com>
Date: Wed Nov 2 23:33:58 2022 +0800
ci: skip sleep when not is_live (#27226)
* ci: skip sleep when not is_live
* ci: apply skip sleep mock for all recorded tests in playback mode
* refactor: mock a public method instead of a private one
* refactor: avoid impact all packages
* ci: use sleep_if_live instead of time.sleep
* refactor: mock sleep on HttpTransport
commit 77803aad7455ef5bf18baee571b6bef688c4d0a7
Author: botingwang-msft <114762639+botingwang-msft@users.noreply.github.com>
Date: Wed Nov 2 08:45:03 2022 -0500
add import job owners (#27235)
* add import job owners
* Update .github/CODEOWNERS
* Update fabricbot.json
Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com>
commit 74e27581f993f52321201bab40dc8315392f94d3
Author: David Watrous <509299+dpwatrous@users.noreply.github.com>
Date: Wed Nov 2 09:41:16 2022 -0400
Update CODEOWNERS for Batch (#27253)
commit 701fbd47a660a82a6f10b5b30fa148a8864d2df9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 2 02:21:…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use swagger #904899a23a417768ce1ec1d5f89f33817f8ef8ad