Fix several issues

[jecmenicanikola]

This PR contains:

• Change some namespaces
• Update docstring
• Hide geojson classes

[azure-sdk]

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Maps.Search

[jecmenicanikola]

/check-enforcer evaluate

[dubiety]

@jecmenicanikola , we should make all the GeoJsonxxx classes as internal class. Please refer to how Routing package achieves this. We should use Azure.Core.GeoJson objects. Routing API doesn't have GeoJson classes exposed. Please see https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/maps/Azure.Maps.Routing/api/Azure.Maps.Routing.netstandard2.0.cs.

[jecmenicanikola]

            #region Snippet:GetPolygon
            GetPolygonOptions options = new GetPolygonOptions()
            {
                Coordinates = new GeoPosition(-122.204141, 47.61256),
                ResultType = BoundaryResultTypeEnum.Locality,
                Resolution = ResolutionEnum.Small,
            };
            Response<Boundary> result = client.GetPolygon(options);
            var count = ((GeoJsonPolygon)((GeoJsonGeometryCollection)result.Value.Geometry).Geometries[0]).Coordinates.Count;
            for (var i = 0; i < count; i++)
            {
                var coorCount = ((GeoJsonPolygon)((GeoJsonGeometryCollection)result.Value.Geometry).Geometries[0]).Coordinates[i].Count;
                for (var j = 0; j < coorCount; j++)
                {
                    Console.WriteLine(string.Join(",", ((GeoJsonPolygon)((GeoJsonGeometryCollection)result.Value.Geometry).Geometries[0]).Coordinates[i][j]));
                }
            }

this in test package, I need to use GeoJsonGeometryCollection and GeoJsonPolygon to cast, so these classes cannot be internal. I don't have corresponding classes in Azure.Core.GeoJson.

[jecmenicanikola]

@dubiety what about my commnet? Are we good to merge this?

[dubiety]

@dubiety what about my commnet? Are we good to merge this?

Using it only for casting doesn't seem right to me. Let me check and I'll get back to you soon.

[dubiety]

#region Snippet:GetPolygon GetPolygonOptions options = new GetPolygonOptions() { Coordinates = new GeoPosition(-122.204141, 47.61256), ResultType = BoundaryResultTypeEnum.Locality, Resolution = ResolutionEnum.Small, }; Response<Boundary> result = client.GetPolygon(options); var count = ((GeoJsonPolygon)((GeoJsonGeometryCollection)result.Value.Geometry).Geometries[0]).Coordinates.Count; for (var i = 0; i < count; i++) { var coorCount = ((GeoJsonPolygon)((GeoJsonGeometryCollection)result.Value.Geometry).Geometries[0]).Coordinates[i].Count; for (var j = 0; j < coorCount; j++) { Console.WriteLine(string.Join(",", ((GeoJsonPolygon)((GeoJsonGeometryCollection)result.Value.Geometry).Geometries[0]).Coordinates[i][j])); } } this in test package, I need to use GeoJsonGeometryCollection and GeoJsonPolygon to cast, so these classes cannot be internal. I don't have corresponding classes in Azure.Core.GeoJson.

For GeoJsonGeometryCollection Can you consider using GeoCollection? I think we should be able to map the object below:

Azure Maps SDK	Azure.Core.GeoJson
GeoJsonGeometryCollection	GeoCollection
GeoJsonGeometry	GeoObject

Azure.Core.GeoJson source code

[jecmenicanikola]

@dubiety I couldn't map these objects

Azure Maps SDK	Azure.Core.GeoJson
GeoJsonGeometryCollection	GeoCollection
GeoJsonGeometry	GeoObject

[dubiety]

@dubiety I couldn't map these objects

Azure Maps SDK Azure.Core.GeoJson
GeoJsonGeometryCollection GeoCollection
GeoJsonGeometry GeoObject

It's fine. I'll fix it. I approved your PR and will merge it.