Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Web PubSub data-plane REST API to 2024-01-01 #44699

Merged
merged 15 commits into from
Jul 22, 2024

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Jun 24, 2024

Summary

Update API version to 2024-01-01

  1. Add method overloads to support specifying client type when generating client URI
  2. Convenient methods to support AddConnectionsToGroups and RemoveConnectionsFromGroups are to be done.

@Y-Sindo Y-Sindo force-pushed the mqttClient branch 2 times, most recently from 52d7fc9 to cfafa1d Compare June 25, 2024 05:52
@Y-Sindo Y-Sindo force-pushed the mqttClient branch 4 times, most recently from bf597bc to 359b2ed Compare June 27, 2024 08:43
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

@Y-Sindo Y-Sindo force-pushed the mqttClient branch 2 times, most recently from 107ceca to 61dab44 Compare June 28, 2024 07:53
@Y-Sindo Y-Sindo changed the title Add "GetClientAccessToken" method for MQTT Upgrade Web PubSub data-plane REST API to 2024-01-01 Jun 28, 2024
@Y-Sindo
Copy link
Member Author

Y-Sindo commented Jul 4, 2024

Hi @schaabs , please help review the API change

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few small things we should iterate on, but it looks good overall.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Messaging.WebPubSub

@Y-Sindo Y-Sindo enabled auto-merge (squash) July 22, 2024 08:19
@Y-Sindo Y-Sindo merged commit e1dd611 into Azure:main Jul 22, 2024
17 checks passed
@Y-Sindo Y-Sindo deleted the mqttClient branch July 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants