-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize additional data in tests #43356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
force-pushed
the
tf-sanitization
branch
from
April 12, 2024 03:30
5d8adf2
to
fd78161
Compare
JoshLove-msft
force-pushed
the
tf-sanitization
branch
from
April 12, 2024 18:14
9c240f6
to
f7e80fa
Compare
Closed
This was referenced Apr 13, 2024
JoshLove-msft
requested review from
jaschrep-msft,
schaabs,
tg-msft,
heaths,
a team,
ShivangiReja,
pallavit,
annelo-msft,
kinelski and
christothes
as code owners
April 16, 2024 05:01
JoshLove-msft
requested review from
maorleger,
billwert,
KarishmaGhiya,
scottaddie and
chlowell
April 16, 2024 05:01
kinelski
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics Advisor changes LGTM.
jsquire
approved these changes
Apr 16, 2024
amnguye
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes the list of sanitized values in the Test Framework and protects against new leaks. Ultimately this will move into the Test Proxy. For now I've left in place the individual library sanitization, but will clean that up in a follow-up PR.