Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LRO rehydration with static method #42686

Merged
merged 36 commits into from
Apr 17, 2024

Conversation

live1206
Copy link
Member

@live1206 live1206 commented Mar 14, 2024

  • Construct RehydrationToken from multiple fields
    • HeaderSource: Indicates where the NextRequestUri locates in the initial response header, it could be OperationLocation, AzureAsyncOperation, Location or None
    • NextRequestUri: The Uri to poll status of the operation
    • InitialUri: The initial Uri of the operation
    • RequestMethod: Http request method of the operation
    • LastKnowLocation: The last known Location value in the response header
    • FinalStateVia: Configuration from API spec, it could be AzureAsyncOperation, Location, OriginalUri or OperationLocation
  • For final get of delete LRO with 404, just return empty response with 204 because the delete succeeded
  • To support LRO rehydration for both DPG and MPG, add static methods to existing Operation for user to consume

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 14, 2024

API change check

API changes are not detected in this pull request.

@christothes christothes requested review from a team and m-nash March 25, 2024 16:47
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of non-blocking comments.

@annelo-msft annelo-msft dismissed their stale review April 9, 2024 15:43

Removing request changes.

@live1206 live1206 merged commit 44d1f56 into Azure:main Apr 17, 2024
36 checks passed
@live1206 live1206 deleted the rehydration-static-method branch April 17, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants