Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to update comment for TokenCacheRefreshArgs.SuggestedCacheKey #28128

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Minor fix to update comment for TokenCacheRefreshArgs.SuggestedCacheKey #28128

merged 4 commits into from
Apr 12, 2022

Conversation

pmaytak
Copy link
Contributor

@pmaytak pmaytak commented Apr 9, 2022

XML comment for TokenCacheRefreshArgs.SuggestedCacheKey is broken in MS Docs. See here. Updated to match the same property in MSAL.NET, which should work.

@ghost ghost added Azure.Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 9, 2022
@ghost
Copy link

ghost commented Apr 9, 2022

Thank you for your contribution @pmaytak! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Apr 9, 2022
@pmaytak pmaytak changed the title Update comment for TokenCacheRefreshArgs.SuggestedCacheKey Minor fix to update comment for TokenCacheRefreshArgs.SuggestedCacheKey Apr 9, 2022
@christothes
Copy link
Member

Hi @pmaytak Thanks for your contribution! Would you be so kind as to fix the trailing space issue called out by the CI? Otherwise, looks great!

@christothes christothes added the needs-author-feedback More information is needed from author to address the issue. label Apr 11, 2022
@pmaytak
Copy link
Contributor Author

pmaytak commented Apr 12, 2022

Hi @pmaytak Thanks for your contribution! Would you be so kind as to fix the trailing space issue called out by the CI? Otherwise, looks great!

@christothes Done. CI builds are successful.

Copy link

@Lillithlilly Lillithlilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public string SuggestedCacheKey { get; }

@christothes christothes merged commit 8724e58 into Azure:main Apr 12, 2022
@pmaytak pmaytak deleted the pmaytak/fix-comment branch April 12, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback More information is needed from author to address the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants