Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyvault] Migrate remaining Key Vault packages to keyvault-common #26875

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

timovv
Copy link
Member

@timovv timovv commented Aug 18, 2023

Packages impacted by this PR

  • @azure/keyvault-keys
  • @azure/keyvault-secrets

Issues associated with this PR

Describe the problem that is addressed by this PR

Noticed that I never actually finished the job for these two packages (oops!) so this PR brings Keys and Secrets up to speed with the latest keyvault-common goodness

timovv added 2 commits August 18, 2023 15:22

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
Copy link

github-actions bot commented Dec 1, 2023

Hi @timovv. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Dec 1, 2023
@timovv timovv removed the no-recent-activity There has been no recent activity on this issue. label Dec 6, 2023
Copy link

github-actions bot commented Feb 9, 2024

Hi @timovv. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Feb 9, 2024
@xirzec xirzec requested a review from maorleger February 15, 2024 20:28
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 15, 2024
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , I used https://github.com/Azure/azure-sdk-for-js/pull/23737/files as the comparison (minus the browser replacements since admin does not have browser support)

@timovv timovv requested a review from a team as a code owner February 16, 2024 17:14
@timovv timovv enabled auto-merge (squash) March 13, 2024 17:54
@timovv timovv merged commit 62ee255 into Azure:main Mar 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[KeyVault] Publish keyvault-common as a package
3 participants