-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keyvault] Migrate remaining Key Vault packages to keyvault-common #26875
Conversation
API change check API changes are not detected in this pull request. |
Hi @timovv. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @timovv. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , I used https://github.com/Azure/azure-sdk-for-js/pull/23737/files as the comparison (minus the browser replacements since admin does not have browser support)
Packages impacted by this PR
@azure/keyvault-keys
@azure/keyvault-secrets
Issues associated with this PR
keyvault-common
as a package #22705Describe the problem that is addressed by this PR
Noticed that I never actually finished the job for these two packages (oops!) so this PR brings Keys and Secrets up to speed with the latest keyvault-common goodness