[Automation] Generate Fluent Lite from TypeSpec playwrighttesting #43410
Conversation
github-actions
bot
added
the
Mgmt
|
API change check APIView has identified API level changes in this PR and created following API reviews. com.azure.resourcemanager:azure-resourcemanager-playwrighttesting |
weidongxu-microsoft
requested review from
weidongxu-microsoft,
haolingdong-msft,
XiaofeiCao and
ArthurMa1978
as code owners
| .append("/") | ||
| .append("1.0.0-beta.3"); | ||
| .append("1.0.0-beta.1"); |
There was a problem hiding this comment.
This version seems not correct.
This is set by package-version/version. It's passed in in autorest, but not in TypeSpec.
Possible solutions:
- Add
package-version/versionto emitter option - In codegen, determine package version(if
versionis absent) - in
updateVersionscript, bump version. Though it'll be a bit tricky to decide the actual xxManager class..
There was a problem hiding this comment.
We can do an emitter option, though sending it across tsp-client may be tricker.
Or a hack via env var...
There was a problem hiding this comment.
env var should do the trick. Yeah, version seems no qualified candidate for an emitter option.
There was a problem hiding this comment.
Seems we have to strip the lib name for tsp-client:
--emitter-options="service-name=Playright" (without @azure-tools/typespec-java)
There was a problem hiding this comment.
Great. So we only need to add (maybe a hidden) package-version, and set this in script.
Let me see if I can include it in the typespec-java release.
[Automation] Generate Fluent Lite from TypeSpec playwrighttesting