Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in
azure-core-test
where the test iteration may not be reset between test runs resulting in a case where a non-parameterized test is believed to have a test iteration that is based on a previously ran parameterized test. This change WILL break test recordings that were given the wrong iteration number. The From Source test run should catch these and will need to be fixed on this PR before it can be merged.There is also a change to plug in a JUnit
ParameterResolver
so thatTestBase
can be instantiated withTestContextManager
instead ofTestInfo
, which means that each test ran will have a completely unique state. Rather than the existing behavior where some information for the test run is global and others it is for the specific test instance.Lastly, while reviewing test configurations I found a lot of tests inspecting for LIVE or PLAYBACK to determine if they should run.
LiveOnly
andPlaybackOnly
annotations (copied from azure-storage-common) were added to act as condition evaluations to determine if a given test should run for a given testing mode.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines