Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search May 2024 Preview Regen #39872

Merged
merged 8 commits into from
May 1, 2024
Merged

Search May 2024 Preview Regen #39872

merged 8 commits into from
May 1, 2024

Conversation

jairmyree
Copy link
Member

Search May 2024 Preview

SearchIndex: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/5a1fe448805429403c38a2637ee32c82ba755530/specification/search/data-plane/Azure.Search/preview/2024-05-01-preview/searchindex.json

SearchService: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/5a1fe448805429403c38a2637ee32c82ba755530/specification/search/data-plane/Azure.Search/preview/2024-05-01-preview/searchservice.json

Search Index Customizations

  • Replaced the method setFields(String) in VectorizableImageUrlQuery with setFields(String...)
  • Replaced the method setFields(String) in VectorizableImageBinaryQuery with setFields(String...)

Search Service Customizations

  • fixed faulty customization for SearchResourceEncryptionKey
    • Utilized customizeAst instead of ClassCustomization methods directly
    • Filed an issue on Autorest.java: here 

Manual Changes

  • Added VectorEncodingFormat to SearchableField and FieldBuilder

@jairmyree jairmyree requested review from alzimmermsft and a team as code owners April 23, 2024 16:57
@jairmyree
Copy link
Member Author

Question Regarding hybridSearch

@alzimmermsft
I'm not quite sure about what to do about the new SearchRequest property Object hybridSearch. Correct me if I'm wrong but I believe it's to be used if you want to set both vector and semantic search options? For now I did not add it to SearchOptions since I'm unsure what to do about it (especially with it being generated with the type Object). Is there any documentation about the function of this hybrid search property?

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-search-documents

@jairmyree
Updates:
4870e1c 
- Updated Cspell
- Rename `maxStoragePerIndex` property to `maxStoragePerIndexInBytes` in SearchServiceLimits
- Set `hybridSearch` property to be type `HybridSearch` in SearchRequest
- Add `hybridSearch` to SearchOptions and `SearchAsyncClient.createSearchRequest()`
@jairmyree jairmyree merged commit a41a0f1 into Azure:main May 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

Assignees
No one assigned
Labels
Search
Projects
Azure SDK for Search
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jairmyree @azure-sdk @alzimmermsft