Schema Registry: Documentation fixes #37913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
approved these changes
Dec 4, 2023
srnagar
approved these changes
Dec 4, 2023
| @@ -12,7 +12,7 @@ schema identifiers rather than full schemas. | |||
|
|
|||
| - A [Java Development Kit (JDK)][jdk_link], version 8 or later. | |||
| - [Azure Subscription][azure_subscription] | |||
| - An [Event Hubs namespace][event_hubs_namespace] | |||
| - An [Event Hubs schema registry][event_hubs_namespace] | |||
There was a problem hiding this comment.
Should we refer to this as Event Hubs Schema Registry or just Schema Registry? Also, fix the link.
Suggested change
| - An [Event Hubs schema registry][event_hubs_namespace] | |
| - An [Event Hubs schema registry][event_hubs_schema_registry] |
| @@ -205,7 +205,7 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m | |||
| [azure_portal]: https://portal.azure.com | |||
| [azure_identity]: https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/identity/azure-identity | |||
| [DefaultAzureCredential]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/README.md#defaultazurecredential | |||
| [event_hubs_namespace]: https://docs.microsoft.com/azure/event-hubs/event-hubs-about | |||
| [event_hubs_namespace]: https://learn.microsoft.com/azure/event-hubs/create-schema-registry | |||
There was a problem hiding this comment.
Suggested change
| [event_hubs_namespace]: https://learn.microsoft.com/azure/event-hubs/create-schema-registry | |
| [event_hubs_schema_registry]: https://learn.microsoft.com/azure/event-hubs/create-schema-registry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes documentation in Schema Registry.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines