Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs. #34306

Merged
merged 5 commits into from
Apr 10, 2023
Merged

update docs. #34306

merged 5 commits into from
Apr 10, 2023

Conversation

g2vinay
Copy link
Member

@g2vinay g2vinay commented Apr 3, 2023 •
edited

  • Updates Samples, Docs and TSG for Azure Developer CLI Credential and Workload Identity Credential.
  • Makes parameters for Workload Identity credential optional and read from env if available.

Fixes #34125
Fixes #34221

@ghost ghost added the Azure.Identity label Apr 3, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@g2vinay g2vinay marked this pull request as ready for review April 3, 2023 17:47
@g2vinay g2vinay requested a review from chlowell April 3, 2023 18:12
joshfree
joshfree approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@joshfree joshfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g2vinay

@joshfree joshfree added this to the 2023-04 milestone Apr 4, 2023
scottaddie
scottaddie reviewed Apr 5, 2023
View reviewed changes
...ntity/azure-identity/src/samples/java/com/azure/identity/credential/JavaDocCodeSnippets.java Outdated Show resolved Hide resolved
...ntity/azure-identity/src/main/java/com/azure/identity/WorkloadIdentityCredentialBuilder.java Outdated Show resolved Hide resolved
...ntity/azure-identity/src/main/java/com/azure/identity/WorkloadIdentityCredentialBuilder.java Outdated Show resolved Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/WorkloadIdentityCredential.java Outdated Show resolved Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/WorkloadIdentityCredential.java Outdated Show resolved Hide resolved
...tity/azure-identity/src/main/java/com/azure/identity/AzureDeveloperCliCredentialBuilder.java Outdated Show resolved Hide resolved
@g2vinay g2vinay merged commit 86b8c90 into Azure:main Apr 10, 2023
14 checks passed
@pvaneck pvaneck mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvaneck pvaneck pvaneck left review comments

@KarishmaGhiya KarishmaGhiya KarishmaGhiya left review comments

@scottaddie scottaddie scottaddie left review comments

@joshfree joshfree joshfree approved these changes

@schaabs schaabs Awaiting requested review from schaabs

@billwert billwert Awaiting requested review from billwert billwert is a code owner

@chlowell chlowell Awaiting requested review from chlowell

Assignees

@g2vinay g2vinay

Labels
Azure.Identity
Projects
None yet
Milestone
2023-04
6 participants
@g2vinay @azure-sdk @joshfree @pvaneck @KarishmaGhiya @scottaddie