-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rooms] Introducing Rooms General Availability Preview #34258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Communication
label
Mar 30, 2023
minnieliu
reviewed
Mar 30, 2023
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
...ation-rooms/src/main/java/com/azure/communication/rooms/implementation/models/RoomModel.java
Show resolved
Hide resolved
...munication-rooms/src/main/java/com/azure/communication/rooms/implementation/models/Role.java
Outdated
Show resolved
Hide resolved
...ation/azure-communication-rooms/src/main/java/com/azure/communication/rooms/models/Role.java
Outdated
Show resolved
Hide resolved
...ication-rooms/src/main/java/com/azure/communication/rooms/models/ParticipantsCollection.java
Outdated
Show resolved
Hide resolved
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Mar 30, 2023
...ure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsServiceVersion.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Mar 30, 2023
...-communication-rooms/src/main/java/com/azure/communication/rooms/models/RoomParticipant.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Mar 30, 2023
...com/azure/communication/rooms/implementation/converters/ParticipantsCollectionConverter.java
Outdated
Show resolved
Hide resolved
...om/azure/communication/rooms/implementation/converters/CommunicationIdentifierConverter.java
Outdated
Show resolved
Hide resolved
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
minnieliu
reviewed
Apr 6, 2023
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Apr 6, 2023
...ure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsServiceVersion.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Apr 6, 2023
minnieliu
reviewed
Apr 6, 2023
minnieliu
reviewed
Apr 6, 2023
...src/main/java/com/azure/communication/rooms/implementation/converters/RoleTypeConverter.java
Show resolved
Hide resolved
minnieliu
reviewed
Apr 6, 2023
...om/azure/communication/rooms/implementation/converters/CommunicationIdentifierConverter.java
Outdated
Show resolved
Hide resolved
Mrayyan
changed the title
[Draft]Feature/rooms general availability
[Rooms] Introducing Rooms General Availability Preview
Apr 12, 2023
minnieliu
requested changes
Apr 17, 2023
...e-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsAsyncClientTests.java
Outdated
Show resolved
Hide resolved
...e-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsAsyncClientTests.java
Show resolved
Hide resolved
...e-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsAsyncClientTests.java
Show resolved
Hide resolved
...ion/azure-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsTestBase.java
Outdated
Show resolved
Hide resolved
...ion/azure-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsTestBase.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Apr 17, 2023
...ion/azure-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsTestBase.java
Outdated
Show resolved
Hide resolved
minnieliu
requested changes
Apr 17, 2023
...ion/azure-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsTestBase.java
Outdated
Show resolved
Hide resolved
...ion/azure-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsTestBase.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Apr 20, 2023
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
.../azure-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsAsyncClient.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Apr 20, 2023
minnieliu
reviewed
Apr 20, 2023
sdk/communication/azure-communication-rooms/src/main/java/module-info.java
Outdated
Show resolved
Hide resolved
minnieliu
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines