udpate access token url on app service #20292
Merged
+13
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiliuTo
requested review from
backwind1233,
chenrujun,
jialindai,
saragluna and
stliu
as code owners
ghost
added
chenrujun
suggested changes
Apr 1, 2021
...lt/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/AuthClient.java
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot-starter-keyvault-certificates/README.md
Outdated
Show resolved
Hide resolved
backwind1233
reviewed
Apr 1, 2021
| if (identity != null) { | ||
| url.append("&clientid=").append(identity); | ||
| if (clientId != null) { | ||
| url.append("&clientid=").append(clientId); |
There was a problem hiding this comment.
what if move "LOGGER.log(INFO, "Using managed identity with client ID: {0}", clientId);" here
There was a problem hiding this comment.
Hi, what is your concern of it? I think it's helpful to inform users about the flow of acquiring tokens and also debug.
There was a problem hiding this comment.
IMU, @backwind1233 's concern is that if (clientId != null) appeared more than one time.
There was a problem hiding this comment.
@chenrujun yes
@yiliuTo
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace parameter from
objectidtoclientidof the access token url on App service.