-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Tables implementation Exception with a public type. #20275
Wrap Tables implementation Exception with a public type. #20275
Conversation
…eption instead of the one in the implementation package.
…tted some code as well.
…ullPointerException when given arguments are incorrect or null. Also changed log level of when the httpClient or pipeline are set to null from INFO to WARNING.
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/TableAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/implementation/Utils.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/implementation/Utils.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/models/TableServiceError.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/implementation/Utils.java
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/src/main/java/com/azure/data/tables/models/TableServiceError.java
Outdated
Show resolved
Hide resolved
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
throw logger.logExceptionAsError( | ||
new IllegalArgumentException( | ||
"'connectionString' missing required settings to derive tables service endpoint.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be split into NPE and IllegalArgumentException as well and also look at all other places where this needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connectionString
is used to obtain the endpoint
, so it would only make sense to throw an NPE if connectionString
itself is null
, right? If endpoint
ends up being null
it would be because the connection string was wither malformed or invalid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreso, the method StorageConnectionString.create()
we use to parse a given connectionString
will throw an IllegalArgumentException
if it's null
. Should we attempt to avoid that behavior and throw an NPE ourselves before calling it?
Changes are separated by commit:
IllegalArgumentException
instead ofNullPointerException
when given arguments are incorrect or null. Also changed log level of when thehttpClient
orpipeline
are set to null from INFO to WARNING. (096b01d)