Default GetSASURL http+https for getsasurl #22704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyasethi-msft
requested review from
siminsavani-msft,
souravgupta-msft,
jhendrixMSFT,
gapra-msft and
vibhansa-msft
as code owners
|
/azp run go - azdatalake |
|
/azp run go - azfile |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run go - azblob |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The changes in this Pull Requests require no further tests - as the existing tests in all 3 modules take care of the functionality. |
|
/azp run go - azblob |
|
/azp run go - azfile |
|
/azp run go - azdatalake |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
souravgupta-msft
approved these changes
Apr 5, 2024
|
Fixes #22448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 2015-04-05, the optional signedProtocol (spr) field specifies the protocol that's permitted for a request made with the SAS.
Possible values are both HTTPS and HTTP (https,http) or HTTPS only (https).
The default value is https,httpRemoved HTTPS protocol from GetSASURL() azfile, azblob and azdatalake in this PR to align with the default http+https behaviour.
Doc - https://learn.microsoft.com/en-us/rest/api/storageservices/create-service-sas?redirectedfrom=MSDN#specify-the-http-protocol