Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzCopy] [Storage] PageBlobClient NewGetPageRangesPager panics if nil options bag is passed #22356

Closed
gapra-msft opened this issue Feb 7, 2024 · 0 comments · Fixed by #22358
Assignees
Labels
AzBlob Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@gapra-msft
Copy link
Member

Bug Report

  • import path of package in question .../storage/azblob
  • SDK version latest,
  • What happened?
    When pageblob.Client.NewGetPageRangesPager(nil) is called and there is a second page expected, the Go SDK panics since it tries to set the NextMarker parameter on a nil options bag. L234 in pageblob/client.go

Mitigation is to pass an empty options bag and instead call it this way pageblob.Client.NewGetPageRangesPager(&pageblob.GetPageRangesOptions{})

  • What did you expect or want to happen?
    Go SDK should check if PageRangeOptions is nil and set it to the empty options bag.

  • How can we reproduce it?
    Instructions given above

  • Anything we should know about your environment.
    N/A

@gapra-msft gapra-msft added Storage Storage Service (Queues, Blobs, Files) AzBlob labels Feb 7, 2024
@jhendrixMSFT jhendrixMSFT added the Client This issue points to a problem in the data-plane of the library. label Feb 7, 2024
@tanyasethi-msft tanyasethi-msft self-assigned this Feb 7, 2024
@vibhansa-msft vibhansa-msft added this to the Storage-Feb-24 milestone Feb 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AzBlob Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants