-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the available role sizes from locations #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the locations client did not return information about the available role sizes in each location. This commit adds two additional properties to the LocationList type to expose a list of Web/Worker role sizes and VM sizes available per region. Since the data is already returned by the API endpoint no API call changes are required.
ruslangabitov
added a commit
that referenced
this pull request
Jan 29, 2015
Include the available role sizes from locations
👍, thanks for merging! |
we should probably delete dev branch unless necessary. (do we use it as a default destination for PRs?) |
Agreed, direct into master would be an improvement. Have a number of patches over the next day or two. |
@ahmetalpbalkan well it was meant for that, but since no one is using it, we can just work in master branch) |
@jen20 thanks for contributing. |
marstr
pushed a commit
to marstr/azure-sdk-for-go
that referenced
this pull request
Apr 27, 2017
* Blobs as receivers, divided blob file * Got rid of extraHeaders on AppendBlob * Progress on general blob operations * Got rid of all extraheaders in general blob operations * Got rid of extraheaders in blockblob * Cuter looking APIs for copy blob * Cuter (more complete) looking APIs for lease blob * Got rid of extraheaders in pageblob * More complete container requests * Better use structToHeaders * Added headersFromStruct to other places and types * Coments from review * Fix tests * More feedback
marstr
pushed a commit
that referenced
this pull request
Apr 28, 2017
* Blobs as receivers, divided blob file * Got rid of extraHeaders on AppendBlob * Progress on general blob operations * Got rid of all extraheaders in general blob operations * Got rid of extraheaders in blockblob * Cuter looking APIs for copy blob * Cuter (more complete) looking APIs for lease blob * Got rid of extraheaders in pageblob * More complete container requests * Better use structToHeaders * Added headersFromStruct to other places and types * Coments from review * Fix tests * More feedback
mcardosos
added a commit
that referenced
this pull request
May 4, 2017
* Blobs as receivers, divided blob file * Got rid of extraHeaders on AppendBlob * Progress on general blob operations * Got rid of all extraheaders in general blob operations * Got rid of extraheaders in blockblob * Cuter looking APIs for copy blob * Cuter (more complete) looking APIs for lease blob * Got rid of extraheaders in pageblob * More complete container requests * Better use structToHeaders * Added headersFromStruct to other places and types * Coments from review * Fix tests * More feedback
richardpark-msft
pushed a commit
to richardpark-msft/azure-sdk-for-go
that referenced
this pull request
Aug 5, 2021
countdetails included. Cant get tests running locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the locations client did not return information about the available role sizes in each location. This commit adds two additional properties to the LocationList type to expose a list of Web/Worker role sizes and VM sizes available per region. Since the data is already returned by the API endpoint no API call changes are required.