Improve test reliability #3052
Merged
Improve test reliability #3052
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Feb 26, 2025
| @@ -3994,6 +3994,9 @@ public async Task DurableEntity_AsyncIO() | |||
| await client.SignalEntity(this.output, "get", "https://www.microsoft.com"); | |||
| await client.SignalEntity(this.output, "get", "https://bing.com"); | |||
|
|
|||
| // Sleeping for a short time here appears to ensure that the state is fully updated before the read | |||
| Thread.Sleep(500); | |||
|
|
|||
| var state = await client.WaitForEntityState<IDictionary<string, string>>(this.output, TimeSpan.FromSeconds(10)); | |||
There was a problem hiding this comment.
I'm wondering, could the client.WaitForEntityState(...) API have been used to account for these delays?
There was a problem hiding this comment.
I was looking at this too... should have marked this PR as a draft, I was just using it to see if an artificial delay helps
cgillum
approved these changes
Feb 26, 2025
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the old end to end tests have been failing intermittently, appears to be an issue with entity state retrieval timing. Add a small delay to hopefully improve reliability.
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.