Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deferred binding attributes #1723

Merged
merged 9 commits into from Jul 10, 2023
Merged

Refactor deferred binding attributes #1723

merged 9 commits into from Jul 10, 2023

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jul 7, 2023 •
edited

Addressing API review feedback:

  1. Rename AllowConverterFallbackAttribute to ConverterFallbackBehaviorAttribute and use enum for determining fallback behavior
  2. Rename SupportedConverterTypeAttribute to SupportedTargetTypeAttribute
  3. Rename ModelBindingDataArray to ModelBindingData

All other changes are fixing things that broke with the rename of those properties and attributes. I had to disable some tests as they require a new worker release with these changes, here's the issue to reenable these:

@liliankasem liliankasem changed the base branch from main to feature/sdk-type-binding July 7, 2023 21:33
@liliankasem liliankasem mentioned this pull request Jul 7, 2023
Closed
1 task
liliankasem added a commit that referenced this pull request Jul 7, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
ba97b1b
fabiocav
fabiocav approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit comments.

src/DotNetWorker.Core/Context/Features/DefaultInputConversionFeature.cs Outdated Show resolved Hide resolved
test/Sdk.Analyzers.Tests/BindingTypeNotSupportedTests.cs Show resolved Hide resolved
src/DotNetWorker.Core/Converters/Converter/ConverterFallbackBehaviorAttribute.cs Outdated Show resolved Hide resolved
liliankasem added a commit that referenced this pull request Jul 10, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
2ece4fa
@liliankasem liliankasem merged commit 2064785 into feature/sdk-type-binding Jul 10, 2023
23 checks passed
@liliankasem liliankasem deleted the liliankasem/refactor branch July 10, 2023 23:36
liliankasem added a commit that referenced this pull request Jul 11, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
0995527
liliankasem added a commit that referenced this pull request Jul 11, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
52b9aec
liliankasem added a commit that referenced this pull request Jul 11, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
50c7010
liliankasem added a commit that referenced this pull request Jul 11, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
424fc1d
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
c454efa
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
8a21409
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
827fdd9
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
0d519cc
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
3c332d8
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
cb7a45b
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
a058f68
liliankasem added a commit that referenced this pull request Jul 13, 2023
@liliankasem
Refactor deferred binding attributes (#1723)
ad46147
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3533b94
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
cc23664
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
206e18b
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
414770b 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem @aishwaryabh
Update EventHub converter and unit tests (#1633, #1716, #1723, #1742)
e56a244 
---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
f3d099a 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
ee372e2
liliankasem added a commit that referenced this pull request Jul 21, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
c763272
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
5b48045 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem @aishwaryabh
Update EventHub converter and unit tests (#1633, #1716, #1723, #1742)
aec4408 
---------

Co-authored-by: Aishwarya Bhandari <aibhandari@microsoft.com>
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
3dd47b6 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 24, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
93ceef1 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 25, 2023
@liliankasem
Queue storage extension support for QueueMessage & BinaryData (#1470, #…
b9b2134 
…1695, #1716, #1723)
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
1e2bb21
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
4004f4c
liliankasem added a commit that referenced this pull request Jul 26, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
d78a268
liliankasem added a commit that referenced this pull request Jul 31, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
39bf886
liliankasem added a commit that referenced this pull request Aug 1, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
0ee7856
liliankasem added a commit that referenced this pull request Aug 1, 2023
@liliankasem
Refactor ServiceBus converter & tests (#1716, #1723, #1727)
f89ff7d
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3ff541a
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
d3fb6a7
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
d77c70e
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
3c485ce
liliankasem added a commit that referenced this pull request Aug 11, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
9eba5d6
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
7819b98
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
7b07011
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
5f6baa0
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
95d8d4a
liliankasem added a commit that referenced this pull request Aug 15, 2023
@liliankasem
Refactor Tables converter & update tests (#1716, #1723, #1727)
5230add
JoshLove-msft pushed a commit to JoshLove-msft/azure-functions-dotnet-worker that referenced this pull request Oct 4, 2023
@liliankasem @JoshLove-msft
Refactor deferred binding attributes (Azure#1723)
082847a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocav fabiocav fabiocav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liliankasem @fabiocav