Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing bypass deferred binding in Source Generator #1610

Merged
merged 13 commits into from
Jun 12, 2023
Merged

Implementing bypass deferred binding in Source Generator #1610

merged 13 commits into from
Jun 12, 2023

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Jun 9, 2023 •
edited

Issue describing the changes in this PR

resolves ##1541

Changes are similar to commit - FunctionMetadataGenerator.cs

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

satvu
satvu approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@satvu satvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@surgupta-msft surgupta-msft merged commit 11e240d into feature/sdk-type-binding Jun 12, 2023
21 checks passed
@surgupta-msft surgupta-msft deleted the surgupta/bypass-deferred-binding-sourcegen branch June 12, 2023 23:57
liliankasem pushed a commit that referenced this pull request Jun 21, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
b767ee8
liliankasem pushed a commit that referenced this pull request Jun 22, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
a3201d4
liliankasem pushed a commit that referenced this pull request Jun 23, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
7d42fcf
liliankasem pushed a commit that referenced this pull request Jun 28, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
119673d
liliankasem pushed a commit that referenced this pull request Jul 5, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
5a6ceb0
liliankasem pushed a commit that referenced this pull request Jul 7, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
a4c5985
liliankasem pushed a commit that referenced this pull request Jul 7, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
835cb16
liliankasem pushed a commit that referenced this pull request Jul 7, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
8db694e
liliankasem pushed a commit that referenced this pull request Jul 11, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
f67098d
liliankasem pushed a commit that referenced this pull request Jul 11, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
eb4b299
liliankasem pushed a commit that referenced this pull request Jul 11, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
90e4e66
liliankasem pushed a commit that referenced this pull request Jul 11, 2023
@surgupta-msft @liliankasem
Implementing bypass deferred binding in Source Generator (#1610)
ce7b2a4
JoshLove-msft pushed a commit to JoshLove-msft/azure-functions-dotnet-worker that referenced this pull request Oct 4, 2023
@surgupta-msft @JoshLove-msft
Implementing bypass deferred binding in Source Generator (Azure#1610)
e7e64c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satvu satvu satvu approved these changes

@liliankasem liliankasem liliankasem approved these changes

@kshyju kshyju Awaiting requested review from kshyju

@jviau jviau Awaiting requested review from jviau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@surgupta-msft @liliankasem @satvu