HTTP Request and Response updates #150
Conversation
fabiocav
force-pushed
the
fabiocav/httpresponse
branch
4 times, most recently
from
9390eca to
457b17e
Compare
| _cookies = cookies; | ||
| } | ||
|
|
||
| public override void Append(string name, string value) |
There was a problem hiding this comment.
Should value be an optional string? value? Per here: https://docs.microsoft.com/en-us/dotnet/api/system.net.cookie.-ctor?view=net-5.0#System_Net_Cookie__ctor_System_String_System_String_
There was a problem hiding this comment.
It's a bit odd... if you look at the remarks for that documentation, it states that the value cannot be null (should be an empty string if not set). The exceptions documentation there also states that a null ref exception will be thrown if the value is null 🤷🏼♂️
There was a problem hiding this comment.
@fabiocav - I think from the code that null will become empty string by default: https://github.com/dotnet/runtime/blob/4893645536af64b01884ce5f3c392ad63513d04b/src/libraries/System.Net.Primitives/src/System/Net/Cookie.cs#L669
Found a related PR here: dotnet/corefx#8206 (which resolves this issue)
And an issue on the docs saying it will throw for null, which appears to be resolved but the docs look the same? :|
There was a problem hiding this comment.
Yeah, looks like a doc issue.
|
|
||
| public bool? Secure { get; set; } | ||
|
|
||
| public string Value { get; set; } |
There was a problem hiding this comment.
Same as earlier comment: string? Value?
There was a problem hiding this comment.
Same comment as above..... not sure we should add...
fabiocav
force-pushed
the
fabiocav/httpresponse
branch
from
457b17e to
c69d63c
Compare
No description provided.